Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add htmlhint #26

Merged
merged 1 commit into from
Feb 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .htmlhintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"doctype-first": false
}
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ RUN pip3 install yamllint
RUN apt-get install -yqq jq
RUN pip3 install yq
RUN npm install -g ajv-cli
RUN npm install -g htmlhint

WORKDIR /exercises-html

Expand Down
16 changes: 7 additions & 9 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ compose:
compose-sut:
docker-compose -f docker-compose.test.yml run sut

compose-code-lint:
docker-compose run exercises make code-lint

compose-description-lint:
docker-compose run exercises make description-lint

Expand All @@ -24,21 +27,16 @@ compose-build:
description-lint:
yamllint modules

code-lint:
htmlhint modules/**/*.{htm,html}

compose-test:
docker-compose run exercises make test

test:
@(for i in $$(find modules/** -type f -name Makefile); do make test -C $$(dirname $$i) || exit 1; done)

check: description-lint schema-validate test

docker-build:
docker build -t hexletbasics/exercises-html .

docker-push:
docker push hexletbasics/exercises-html

docker-release: docker-build docker-push
check: description-lint code-lint schema-validate test

SUBDIRS := $(wildcard modules/**/*/.)

Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ $ make compose
$ make compose-test

# run linters and validators
$ make compose-code-lint
$ make compose-description-lint
$ make compose-schema-validate
```
Expand Down