Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby #1

Merged
merged 6 commits into from Jan 9, 2019
Merged

Add Ruby #1

merged 6 commits into from Jan 9, 2019

Conversation

Morozzzko
Copy link
Contributor

Скопировал и подтюнил exercises-python

Что есть:

  • Установка
  • Модули
  • Перехват stdout участника

Чего нет: ассертов

mokevnin
mokevnin reviewed Jan 9, 2019
View reviewed changes
modules/10-basics/10-hello-world/test.rb
load(index_file_path)
end

raise unless actual == 'Hello, World!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless читаем только с унарными операциями

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хотелось видеть тут ассерты перед мержем, но 🤔

@mokevnin mokevnin merged commit 3b6f487 into hexlet-basics:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokevnin mokevnin mokevnin left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Morozzzko @mokevnin