Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add faq #793

Closed
wants to merge 1 commit into from
Closed

add faq #793

wants to merge 1 commit into from

Conversation

fey
Copy link
Collaborator

@fey fey commented Sep 13, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020 •
edited
Loading

Codecov Report

Merging #793 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   78.50%   78.56%   +0.05%     
==========================================
  Files          87       87              
  Lines        1554     1558       +4     
==========================================
+ Hits         1220     1224       +4     
  Misses        334      334
Impacted Files Coverage Δ
services/app/lib/codebattle/languages.ex 100.00% <0.00%> (ø)
services/app/lib/codebattle/tournament.ex 100.00% <0.00%> (ø)
services/app/lib/codebattle/tournament/types.ex 75.00% <0.00%> (ø)
...p/lib/codebattle_web/live/tournament/index_view.ex 100.00% <0.00%> (ø)
...rvices/app/lib/codebattle/tournament/individual.ex 92.10% <0.00%> (+0.21%) ⬆️
services/app/lib/codebattle/tournament/team.ex 96.77% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8011e...f2ea5e9. Read the comment docs.

vtm9
vtm9 reviewed Sep 13, 2020
View reviewed changes
Copy link
Contributor

@vtm9 vtm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo, можешь лучше ридми расширить?
Там есть сама команда без описания

vtm9
vtm9 requested changes Sep 13, 2020
View reviewed changes
FAQ.md
$ mix dockers.build <lang> // например php
// Либо снаружи на хосте
$ docker-compose run app mix dockers.build lang="<lang>"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to readme.md

@fey
Copy link
Collaborator Author

fey commented Sep 13, 2020

Ок, давай в ридми подправлю.

@fey fey marked this pull request as draft September 14, 2020 09:17
@fey fey closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtm9 vtm9 vtm9 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fey @codecov-commenter @vtm9