add tests #203
Merged
add tests #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fey
reviewed
Feb 14, 2023
.github/workflows/pull-request.yml
Outdated
| run: | | ||
| make db-migrate & | ||
| npx playwright install --with-deps & | ||
| make test-e2e |
There was a problem hiding this comment.
ты можешь сделать отдельную джобу в воркфлоу, чтобы у тебя параллельно работали тесты обычные и е2е. Плюс здесь команда слишком страшная, можно обернуть в некий make ci-e2e-tests.
Плюс команды через амперсанд запускаются. А так должно быть?
fey
reviewed
Feb 14, 2023
package.json
Outdated
| @@ -6,8 +6,9 @@ | |||
| "scripts": { | |||
| "build": "npm run build --prefix frontend && npm run build --prefix backend", | |||
| "start:prod": "npm run start:prod --prefix backend", | |||
| "test": "echo \"Error: no test specified\" && exit 1", | |||
| "preinstall": "npm ci --prefix frontend && npm ci --prefix backend" | |||
| "preinstall": "npm ci --prefix frontend && npm ci --prefix backend", | |||
There was a problem hiding this comment.
по семантике preinstall некорректно использовать для установки зависимостей. Это скорее для всяких хуков-скриптов.
Можно попробовать в виде воркспейсов тут
вот как у нас в домашках было
"workspaces": [
"./exercises/*"
],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.