Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sinon to 6.3.5 #34

Merged
merged 1 commit into from Oct 11, 2018

Conversation

3 participants
@YoshinoriN
Copy link
Member

commented Oct 10, 2018

From (#32) PR.

Update sinon 6.3.5
The sinon has breaking change. So, this PR fix test case.

@coveralls

This comment has been minimized.

Copy link

commented Oct 10, 2018

Coverage Status

Coverage remained the same at 85.714% when pulling 3782c72 on YoshinoriN:update-sinon into 3dcd35e on hexojs:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Oct 10, 2018

Coverage Status

Coverage remained the same at 85.714% when pulling 3782c72 on YoshinoriN:update-sinon into 3dcd35e on hexojs:master.

@segayuu
Copy link
Contributor

left a comment

LGTM!

@segayuu segayuu merged commit ddd2044 into hexojs:master Oct 11, 2018

4 checks passed

codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.714%
Details

@YoshinoriN YoshinoriN deleted the YoshinoriN:update-sinon branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.