Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sinon to 6.3.5 #34

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Update sinon to 6.3.5 #34

merged 1 commit into from
Oct 11, 2018

Conversation

yoshinorin
Copy link
Member

From (#32) PR.

Update sinon 6.3.5
The sinon has breaking change. So, this PR fix test case.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.714% when pulling 3782c72 on YoshinoriN:update-sinon into 3dcd35e on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.714% when pulling 3782c72 on YoshinoriN:update-sinon into 3dcd35e on hexojs:master.

segayuu
segayuu approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@segayuu segayuu merged commit ddd2044 into hexojs:master Oct 11, 2018
@yoshinorin yoshinorin deleted the update-sinon branch October 11, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshinorin @coveralls @segayuu