-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image enclosure with post.image metadata #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is LGTM.
But, it seems post.image
is not a default value of post.
How do you think about use of not default value ?
@hexojs/core
And I want to other maintainer's opnion.
@yoshinorin it's not a default value indeed. I have built this assumption because the built-in
On the other hand, I can see there is a What do you think? I can create a PR in hexo to make the |
Oh, I didn't notice it. I think it's enough reason for merge this PR. |
Excellent. Let me know if you think of something else before merging this PR. |
@oncletom |
Thanks. Done ! |
Thank you 🙂 |
Do you think you (or someone else) could tag a new (minor) release and publish it on npm? |
No. I think it's better. But, I have no permission of publish to npm. |
A good thing would be to deploy automatically on npm on a new Git tag. I can create a PR with what's needed if that's something you would lean towards. Although the CI would still have to be configured by someone with a valid npm access token. |
When a
post
has animage
front matter, it gets displayed as:<enclosure type=image url="http://bloguri/{{ post.image }}" />
for RSS2 output<content type=image src="http://bloguri/{{ post.image }}" />
for Atom output