Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rss autodiscovery #96

Merged
merged 7 commits into from Sep 26, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Sep 24, 2019

Many (most?) themes already offer this feature, but this plugin should've added it in the first place.

ref: http://www.rssboard.org/rss-autodiscovery
credit: meta_generator.js

curbengh added 4 commits Sep 24, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 77c95f9 on curbengh:autodiscovery into d66f225 on hexojs:master.

curbengh added 3 commits Sep 24, 2019
@SukkaW

This comment has been minimized.

Copy link
Member

SukkaW commented Sep 24, 2019

IMHO, the default config should be false.

@SukkaW

This comment has been minimized.

Copy link
Member

SukkaW commented Sep 24, 2019

README should be updated as well.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Sep 25, 2019

IMHO, the default config should be false.

Please give a valid reason. It's part of the specification so most RSS reader program/plugin should support it and site with RSS is expected to have it. I would find it puzzling that users wouldn't want this feature turned on after installing this plugin.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Sep 25, 2019

Many theme has already support RSS autodiscovery.

I'm aware of that, I already mentioned

#96 (comment)
Many (most?) themes already offer this feature, but this plugin should've added it in the first place.


RSS Autodiscovery is also one of the item from hexo-theme-unit-test Checklist

Popular themes indeed would (and should) pass that checklist, but we can't guarantee all available themes have that. Some themes disable by default as they didn't implement mechanism to add it automatically when hexo-generator-feed is installed.

@SukkaW
SukkaW approved these changes Sep 26, 2019
@curbengh curbengh merged commit a0cca0b into hexojs:master Sep 26, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@curbengh curbengh deleted the curbengh:autodiscovery branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.