Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rss autodiscovery #96

Merged
merged 7 commits into from Sep 26, 2019
Merged

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Sep 24, 2019

Many (most?) themes already offer this feature, but this plugin should've added it in the first place.

ref: http://www.rssboard.org/rss-autodiscovery
credit: meta_generator.js

@coveralls
Copy link

coveralls commented Sep 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 77c95f9 on curbengh:autodiscovery into d66f225 on hexojs:master.

@SukkaW
Copy link
Member

SukkaW commented Sep 24, 2019

IMHO, the default config should be false.

@SukkaW
Copy link
Member

SukkaW commented Sep 24, 2019

README should be updated as well.

@curbengh
Copy link
Contributor Author

curbengh commented Sep 25, 2019

IMHO, the default config should be false.

Please give a valid reason. It's part of the specification so most RSS reader program/plugin should support it and site with RSS is expected to have it. I would find it puzzling that users wouldn't want this feature turned on after installing this plugin.

@curbengh
Copy link
Contributor Author

Many theme has already support RSS autodiscovery.

I'm aware of that, I already mentioned

#96 (comment)
Many (most?) themes already offer this feature, but this plugin should've added it in the first place.


RSS Autodiscovery is also one of the item from hexo-theme-unit-test Checklist

Popular themes indeed would (and should) pass that checklist, but we can't guarantee all available themes have that. Some themes disable by default as they didn't implement mechanism to add it automatically when hexo-generator-feed is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants