Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url_for & full_url_for): ignore data url #130

Merged
merged 2 commits into from Nov 17, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Nov 10, 2019

Fixes #122

BREAKING CHANGE: drop support for pathname with semicolon

cc @lookis

BREAKING CHANGE: drop support for pathname with semicolon
@curbengh curbengh requested a review from hexojs/core Nov 10, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 10, 2019

Coverage Status

Coverage decreased (-0.03%) to 95.364% when pulling 19d02e7 on curbengh:mailto-url-for into 71fce3f on hexojs:master.

lib/full_url_for.js Outdated Show resolved Hide resolved
@curbengh curbengh requested a review from SukkaW Nov 17, 2019
@SukkaW
SukkaW approved these changes Nov 17, 2019
@tomap
tomap approved these changes Nov 17, 2019
@SukkaW SukkaW merged commit 4d14828 into hexojs:master Nov 17, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.03%) to 95.364%
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@curbengh curbengh mentioned this pull request Nov 17, 2019
@curbengh curbengh deleted the curbengh:mailto-url-for branch Nov 17, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 29, 2019
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.