-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow backtick code block in "blockquote" tag plugin (#2318) #2321
Allow backtick code block in "blockquote" tag plugin (#2318) #2321
Conversation
Could you please also add the test case for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, all tags which have ends: true
parameter not working correctly in each other. For example, codeblock also won't work in note
(bscallout) tag.
This pull usefull and non merged from 19 Dec 2016. Is this +0.008% coverage so important to freeze bug for 1.5 years?
@seaoak |
@weyusi @NoahDragon @hexojs/core I propose we re-create other PR instead of this PR if @seaoak will not react our mention. |
Good idea @yoshinorin |
@yoshinorin |
Sorry, I'm too late to response you. I was busy over the past year, but quite recently I have a little time to enjoy programming. If anymone takes this PR, I'm pleased to leave this PR. 😄 |
Welcome back seaoka !! |
@seaoak Please resolve the conflict. |
Any updates on this thread? |
When backtick code block(s) exist as contents of a "blockquote" tag plugin, each code block is translated to a string "undefined" in HTML (Issue hexojs#2318). In analyzing markdown source text, while the replacement of these elements with placeholders are nesting, recoveries from placeholders are executed only once. So I modify to repeat the recovery process until all placeholders are recovered.
I'm sorry I restarted to catch up latest Hexo last month. I'll be glad if you give me a chance to update this patch. |
bb9aaa5
to
1c58748
Compare
I rewrite this patch for latest Hexo. @hexojs/core Could you please review? By the way #3318 is not fixed by this patch. NOTE: |
Travis CI erros only on Node.js 6.x. May I adjust build options of this PR? (Although I'm not familiar with Travis CI...) |
@sseaoak We have already drop node 6 for Travis CI in #3598 I will trigger a rebuild for you. |
It's fine to rebase to the latest master (in fact I often do it), which would require forced push. Rebasing is necessary in this PR resolve the CI issue. |
test/scripts/hexo/post.js
Outdated
@@ -717,4 +717,27 @@ describe('Post', () => { | |||
}); | |||
}); | |||
|
|||
// test for Issue [#2318](https://github.com/hexojs/hexo/issues/2318) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think // test for Issue #2318
is sufficient without the full link.
I created a fix hexojs/hexo-util#110 for those issues. Tested with this PR. But the fix comes with some caveat; oh well, I would suggest user to use |
1c58748
to
8240f14
Compare
I've rebased this PR, so all test pass now. My apology if this come off as a bit rude, I just want to include this PR into v4. |
@curbengh Thank you for your review and rebase! 😄 |
hexojs#2321) * test(backtick): update comment * Allow backtick code block in "blockquote" tag plugin (hexojs#2318) When backtick code block(s) exist as contents of a "blockquote" tag plugin, each code block is translated to a string "undefined" in HTML (Issue hexojs#2318). In analyzing markdown source text, while the replacement of these elements with placeholders are nesting, recoveries from placeholders are executed only once. So I modify to repeat the recovery process until all placeholders are recovered. * require assert
When backtick code block(s) exist as contents of a "blockquote" tag plugin,
each code block is translated to a string "undefined" in HTML (Issue #2318).
In analyzing markdown source text, while the replacement of these elements
with placeholders are nesting, recoveries from placeholders are executed
only once. So I modify to repeat the recovery process until all
placeholders are recovered.
NOTE: From Pull Request #2319, I correct the condition of exception (accept empty string as escape content).