Misc: add meta generator injection filter #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segayuu
reviewed
Apr 20, 2018
lib/plugins/filter/meta_generator.js
Outdated
| @@ -0,0 +1,18 @@ | |||
| 'use strict'; | |||
|
|
|||
| const rMetaGenerator = /<meta\s+name=['|"]?generator['|"]?/i; | |||
There was a problem hiding this comment.
Current code will recognize incorrect expressions as html.
<meta name="generator'>
Also, | is described in the character set, this expression will detect <meta name=|generato |>. Is this just as intended?
There was a problem hiding this comment.
I prepared regExp which seems to be able to express the intention of writing regExp.
/<meta\s+name=(["']?)generator\1(?: [^>\n]+)?>/i
|
Thanks for review! And the task about this in 4.0 Roadmap could be marked as finished. |
2 tasks
This was referenced Oct 26, 2018
NoahDragon
added a commit
to hexojs/site
that referenced
this pull request
Nov 2, 2018
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:
This implements the
meta generator injectionfeature. For more information, see Miscellaneous section of Hexo 4.0 Roadmap, and hexojs/site#649.