Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for nodejs v11 or higher #3305

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Oct 25, 2018

At node v11, the current test fails.
The initial value of the depth option of util.inspect() has changed since node v11.
node v11: 20 node v10: 2
Given the default value change, it is clear that the test on this line will fail on v11.

  • Add test cases for the changes.
  • Passed the CI test.

@segayuu segayuu requested a review from a team October 25, 2018 00:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.27% when pulling dd1fbc4 on fix-test-for-nodejs-latest into 8d33f3c on master.

@segayuu segayuu mentioned this pull request Oct 25, 2018
2 tasks
@segayuu segayuu added the bug Something isn't working label Oct 25, 2018
@segayuu
Copy link
Contributor Author

segayuu commented Oct 25, 2018

I confirmed that CI passed. If this PR merge is delayed, all other PR tests will fail, so use the administrator authority to merge.

@segayuu segayuu merged commit bbc2f04 into master Oct 25, 2018
@segayuu segayuu deleted the fix-test-for-nodejs-latest branch October 25, 2018 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants