Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spread function: Hexo#_generate() #3359

Merged

Conversation

4 participants
@segayuu
Copy link
Contributor

commented Nov 16, 2018

Even if the current Hexo#_generate() is divisible as an internal API, it still is big and feels chaotic.
This PR aims to divide _generate() and make the behavior clearer.

  • Add test cases for the changes.
  • Passed the CI test.

@segayuu segayuu requested a review from hexojs/core Nov 16, 2018

@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2018

Coverage Status

Coverage increased (+0.004%) to 97.259% when pulling e97ce48 on segayuu:Spread-function-generate-Hexo-internal-method into 6411abf on hexojs:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2018

Coverage Status

Coverage increased (+0.004%) to 97.259% when pulling e97ce48 on segayuu:Spread-function-generate-Hexo-internal-method into 6411abf on hexojs:master.

@tomap

tomap approved these changes Nov 16, 2018

@segayuu segayuu merged commit eacf0a1 into hexojs:master Nov 16, 2018

4 checks passed

codeclimate 1 fixed issue
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 97.259%
Details

@segayuu segayuu deleted the segayuu:Spread-function-generate-Hexo-internal-method branch Nov 16, 2018

YoshinoriN added a commit to YoshinoriN/hexo that referenced this pull request Nov 16, 2018

fix(generator): fix site is not defined error
* Locals.prototype.site is deleted in (hexojs#3359)

@YoshinoriN YoshinoriN referenced this pull request Nov 16, 2018

Merged

fix(generator): fix site is not defined error #3360

0 of 2 tasks complete
@YoshinoriN

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

@segayuu
This change has error. Please see (#3360) PR.

YoshinoriN added a commit that referenced this pull request Nov 16, 2018

fix(generator): fix site is not defined error (#3360)
* Locals.prototype.site is deleted in (#3359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.