Spread function: Hexo#_generate() #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
tomap
approved these changes
Nov 16, 2018
yoshinorin
added a commit
to yoshinorin/hexo
that referenced
this pull request
Nov 16, 2018
* Locals.prototype.site is deleted in (hexojs#3359)
2 tasks
yoshinorin
added a commit
that referenced
this pull request
Nov 16, 2018
* Locals.prototype.site is deleted in (#3359)
thom4parisot
pushed a commit
to thom4parisot/hexo
that referenced
this pull request
Jan 17, 2020
* Locals.prototype.site is deleted in (hexojs#3359)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the current
Hexo#_generate()is divisible as an internal API, it still is big and feels chaotic.This PR aims to divide
_generate()and make the behavior clearer.