Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if post.title is empty, set it to post.slug #3672

Merged
merged 1 commit into from Aug 30, 2019
Merged

if post.title is empty, set it to post.slug #3672

merged 1 commit into from Aug 30, 2019

Conversation

@rupertqin
Copy link
Contributor

@rupertqin rupertqin commented Aug 16, 2019

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls
Copy link

@coveralls coveralls commented Aug 16, 2019

Coverage Status

Coverage increased (+0.002%) to 97.156% when pulling af5e7b4 on rupertqin:master into 3176fe0 on hexojs:master.

Copy link
Contributor

@curbengh curbengh left a comment

Also works in an empty file.

@curbengh curbengh added this to the v4.0.0 milestone Aug 21, 2019
@curbengh curbengh requested a review from Aug 30, 2019
Copy link
Member

@yoshinorin yoshinorin left a comment

@rupertqin Thank you for your contribution :)

@stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Apr 22, 2020

According to hexo-theme-unit-test, posts without title should be the feature of Hexo themes.

This Pull Request makes "Posts without title should be accessible" impossible. Need to reconsider this feature or update related documents.

https://github.com/hexojs/hexo-theme-unit-test#post
#4228

@SukkaW SukkaW mentioned this pull request Apr 22, 2020
@SukkaW
Copy link
Member

@SukkaW SukkaW commented Apr 25, 2020

#3672 (comment)

@stevenjoezhang Added to Hexo 5.0.0 Roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants