Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if post.title is empty, set it to post.slug #3672

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@rupertqin
Copy link
Contributor

rupertqin commented Aug 16, 2019

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage increased (+0.002%) to 97.156% when pulling af5e7b4 on rupertqin:master into 3176fe0 on hexojs:master.

Copy link
Contributor

curbengh left a comment

Also works in an empty file.

@curbengh curbengh added this to the v4.0.0 milestone Aug 21, 2019
@curbengh curbengh requested a review from hexojs/core Aug 30, 2019
Copy link
Member

YoshinoriN left a comment

@rupertqin Thank you for your contribution :)

@YoshinoriN YoshinoriN merged commit f57f700 into hexojs:master Aug 30, 2019
4 checks passed
4 checks passed
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.156%
Details
curbengh added a commit to curbengh/hexo-site that referenced this pull request Sep 2, 2019
curbengh added a commit to curbengh/hexo-site that referenced this pull request Sep 2, 2019
curbengh added a commit to curbengh/hexo-site that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.