-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(open_graph): add article:published_time & article:modified_time #3674
Conversation
rebased |
Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
article:modified_time
as it duplicatesog:updated_time
.
og:updated_time
seems to be deprecated for a very long time and was replaced by article:modified_time
.
Maybe we should use article:modified_time
at post and use og:updated_time
at other pages, just as hugo does.
I will add |
I've replaced |
- duplicate of 'og:updated_time'
- og:updated_time has been deprecated
Since Should we add |
Are we going to deprecate |
What does it do?
article:published_time
andarticle:modified_time
are listed in the Open Graph spec. The spec doesn't includeog:updated_time
(removed in more recent spec?), but somehow it's widely adopted (thanks to Yoast?).Edit:
og_updated_time
has been deprecated, hence it's not included in the spec. This PR replaces it witharticle:modified_time
.How to test
Pull request tasks