Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(open_graph): add article:published_time & article:modified_time #3674

Merged
merged 6 commits into from
Oct 26, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 16, 2019

What does it do?

article:published_time and article:modified_time are listed in the Open Graph spec. The spec doesn't include og:updated_time (removed in more recent spec?), but somehow it's widely adopted (thanks to Yoast?).

Edit: og_updated_time has been deprecated, hence it's not included in the spec. This PR replaces it with article:modified_time.

How to test

git clone -b og-updated https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

@coveralls
Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage increased (+0.003%) to 97.27% when pulling a081077 on curbengh:og-updated into 5d94690 on hexojs:master.

@curbengh
Copy link
Contributor Author

rebased

@curbengh curbengh changed the title feat(open_graph): add article:published_time & article:modified_time feat(open_graph): add article:published_time Oct 17, 2019
@curbengh
Copy link
Contributor Author

Removed article:modified_time as it duplicates og:updated_time.

@curbengh curbengh requested a review from a team October 17, 2019 06:40
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed article:modified_time as it duplicates og:updated_time.

og:updated_time seems to be deprecated for a very long time and was replaced by article:modified_time.

Maybe we should use article:modified_time at post and use og:updated_time at other pages, just as hugo does.

@SukkaW
Copy link
Member

SukkaW commented Oct 17, 2019

I will add article:author and article:tag tag for post in a separate PR.

@curbengh
Copy link
Contributor Author

curbengh commented Oct 17, 2019

I've replaced og:updated_time with article:modified_time.

@curbengh curbengh changed the title feat(open_graph): add article:published_time feat(open_graph): add article:published_time & article:modified_time Oct 17, 2019
@curbengh
Copy link
Contributor Author

curbengh commented Oct 18, 2019

og:updated_time seems to be deprecated for a very long time and was replaced by article:modified_time.

Maybe we should use article:modified_time at post and use og:updated_time at other pages, just as hugo does.

Since og:updated_time has been deprecated, then we should just remove it.

Should we add article:published_time & article:modified_time to post only? I don't mind whether it's post only or all pages; personally I find it useful to see published and modified time in the html source, even though the page doesn't show it or not an article/post.

@curbengh
Copy link
Contributor Author

I will add article:author and article:tag tag for post in a separate PR.

Are we going to deprecate keywords? I just looked around, it seems to be deprecated as well.

@curbengh curbengh added this to the v4.1.0 milestone Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants