Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(paginator): compatibility with hexo-util@1.3.0 #3728

Merged
merged 6 commits into from
Sep 27, 2019
Merged

fix(paginator): compatibility with hexo-util@1.3.0 #3728

merged 6 commits into from
Sep 27, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Sep 22, 2019 •
edited
Loading

What does it do?

htmlTag in hexo-util@1.3.0 onward escape html tag and encode url by default. This PR adds trailing slash to expected value of href; trailing slash is added by encodeURL() of html-util.

In paginator helper,

How to test

git clone -b escape-html https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Sep 22, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.248% when pulling 6fd5231 on curbengh:escape-html into 53ebe22 on hexojs:master.

@curbengh
Copy link
Contributor Author

Pending hexojs/hexo-util#102

@curbengh
Copy link
Contributor Author

Pending hexojs/hexo-util#103

This was referenced Sep 23, 2019
Closed
Merged
@curbengh curbengh added this to the v4.0.0 milestone Sep 23, 2019
This was referenced Sep 24, 2019
Merged
Merged
@SukkaW SukkaW mentioned this pull request Sep 26, 2019
Merged
@curbengh curbengh marked this pull request as ready for review September 27, 2019 00:30
@curbengh
Copy link
Contributor Author

Ready

@curbengh curbengh requested a review from a team September 27, 2019 00:31
@curbengh curbengh changed the title fix: compatibility with hexo-util@1.3.0 fix(paginator): compatibility with hexo-util@1.3.0 Sep 27, 2019
@curbengh curbengh merged commit ffe4eaa into hexojs:master Sep 27, 2019
@curbengh curbengh deleted the escape-html branch September 27, 2019 02:41
DIYgod added a commit to DIYgod/diygod.me that referenced this pull request Oct 18, 2019
@DIYgod
fix: escape option for paginator - hexojs/hexo#3728
922cf86
@curbengh curbengh mentioned this pull request Oct 24, 2019
Merged
15 tasks
@curbengh curbengh mentioned this pull request Dec 6, 2019
Merged
2 tasks
@SukkaW SukkaW mentioned this pull request Jan 4, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
comicat-hu added a commit to comicat-hu/hexo-theme-cafe that referenced this pull request Jul 22, 2020
@comicat-hu
disable escape setting in paginator for hexo 4.0+
8f26a85 
* see hexojs/hexo#3728
@comicat-hu comicat-hu mentioned this pull request Jul 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

pagination parsing error(分页编译错误)
3 participants
@curbengh @coveralls @SukkaW