fix(moment.locale): avoid lookup repeatedly with the wrong names.

[dailyrandomphoto]

What does it do?

Hexo language code is different with Moment.js.
If we set language like this,

# _config.yml
language:
timezone:

or

# _config.yml
language: zh-CN
timezone:

then default or zh-CN will pass to moment.locale(lang).

const lang = this.page.lang || this.page.language || config.language;
...
if (lang) date = date.locale(lang); // lang = 'default' or 'zh-CN'

Whenever .locale (lang) is called, it causes moment to find the locale file repeatedly.

This PR adds toMomentLocale() to convert lang code, avoid lookup repeatedly with the wrong names.

How to test

git clone -b fix-moment-locale https://github.com/dailyrandomphoto/hexo.git
cd hexo
npm install
npm test

Pull request tasks

• Add test cases for the changes.
• Passed the CI test.

[coveralls]

Coverage increased (+0.005%) to 97.082% when pulling 531780f on dailyrandomphoto:fix-moment-locale into 92c705d on hexojs:master.

[dailyrandomphoto]

A benchmark using a hexo dummy website (with 900 posts):

Measure 5 times and calculate the average for each benchmark.

Node.js 8

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master: lang = en	61.816s	1.997s	1060.584MB	43.517s	1.828s	1109.915MB
master: lang = zh-CN	60.432s	1.902s	1046.009MB	42.284s	1.763s	1102.388MB
this PR: lang = zh-CN	60.407s	1.957s	1049.878MB	42.187s	1.794s	1103.745MB

Node.js 10

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master: lang = en	50.663s	1.814s	1074.596MB	36.368s	1.709s	1104.663MB
master: lang = zh-CN	52.358s	1.832s	1072.98MB	37.554s	1.74s	1106.869MB
this PR: lang = zh-CN	50.324s	1.805s	1073.225MB	36.904s	1.707s	1111.981MB

Node.js 12

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master: lang = en	52.957s	1.937s	1076.198MB	38.374s	1.87s	1101.208MB
master: lang = zh-CN	54.357s	1.927s	1102.307MB	38.912s	1.826s	1111.927MB
this PR: lang = zh-CN	50.377s	1.874s	1077.271MB	36.067s	1.755s	1110.664MB

Node.js 13

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master: lang = en	50.829s	1.815s	1081.803MB	37.32s	1.718s	1100.031MB
master: lang = zh-CN	52.473s	1.792s	1070.279MB	37.974s	1.745s	1097.203MB
this PR: lang = zh-CN	51.496s	1.805s	1075.648MB	36.472s	1.699s	1100.096MB

[dailyrandomphoto]

options.language always is undefined.
This is a bug, or this is unnecessary code.

[SukkaW]

As far as I know, models/types/moment is only used in Post and Page model.

hexo/lib/models/page.js

Line 13 in 140ed36

type: Moment,

hexo/lib/models/post.js

Line 23 in 140ed36

type: Moment,

What happened then is still a mystery. Only tommy351 knows.

[dailyrandomphoto]

Benchmark for relative_link: true

A benchmark using a hexo dummy website (with 900 posts):

Measure 5 times and calculate the average for each benchmark.

Benchmark conditions:

• common:
  • language: zh-CN
  • relative_link: true
• master:
  • version: Before fix(moment.locale): avoid lookup repeatedly with the wrong names. #4007. commit

Node.js 8

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master	148.839s	2.38s	1102.397MB	125.162s	2.111s	1181.39MB
this PR	81.695s	2.219s	1112.943MB	63.956s	1.973s	1172.119MB

Node.js 10

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master	121.885s	2.045s	1203.274MB	106.81s	1.859s	1242.954MB
this PR	68.21s	2.045s	1167.641MB	53.912s	1.888s	1206.12MB

Node.js 12

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master	127.652s	2.065s	1128.723MB	114.08s	1.953s	1210.77MB
this PR	69.073s	2.112s	1141.249MB	54.851s	1.945s	1183.367MB

Node.js 13

	Total time (Cold)	Save DB (Cold)	Memory (Cold)	Total time (Hot)	Save DB (Hot)	Memory (Hot)
master	125.619s	2s	1129.541MB	114.066s	1.898s	1181.748MB
this PR	69.611s	2.1s	1125.007MB	54.739s	1.915s	1158.469MB