Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag): add unregister() method #4046

Merged
merged 1 commit into from Jan 4, 2020
Merged

feat(tag): add unregister() method #4046

merged 1 commit into from Jan 4, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jan 1, 2020

What does it do?

Closes #3457.

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Related API Documents:

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from a team January 1, 2020 18:22
@SukkaW SukkaW mentioned this pull request Jan 1, 2020
Closed
@coveralls
Copy link

coveralls commented Jan 1, 2020 •
edited

Coverage Status

Coverage increased (+0.002%) to 97.426% when pulling 0f89204 on SukkaW:feat-unregister-tag into a9bbc42 on hexojs:master.

@SukkaW SukkaW mentioned this pull request Jan 1, 2020
Closed
yoshinorin
yoshinorin approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@SukkaW SukkaW merged commit a69d970 into hexojs:master Jan 4, 2020
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@SukkaW
feat(tag): add unregister() method (hexojs#4046)
3d8125d
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
Merged
22 tasks
@curbengh curbengh mentioned this pull request Aug 3, 2020
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a way to unregister a tag
3 participants
@SukkaW @coveralls @yoshinorin