Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test-hexo): async/await #4389

Merged
merged 2 commits into from
Jun 30, 2020
Merged

refactor(test-hexo): async/await #4389

merged 2 commits into from
Jun 30, 2020

Conversation

curbengh
Copy link
Contributor

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

SukkaW
SukkaW approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I am worried about async/await causing failed ci tests.

@curbengh
Copy link
Contributor Author

async/await causing failed ci tests.

the whole codebase eventually will be updated to async/await. Failing CI test either can be fixed or at least a workaround.

@curbengh curbengh merged commit f4f5510 into hexojs:master Jun 30, 2020
@curbengh curbengh deleted the test-hexo-async branch June 30, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curbengh @SukkaW