Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that a resource leak #81

Merged
merged 1 commit into from
May 12, 2020
Merged

Fix bug that a resource leak #81

merged 1 commit into from
May 12, 2020

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented May 11, 2020

Fixed a bug that a resource leak occurs without being notified to readStream when a json parse error occurs in Database#load().
In hexojs/hexo#3975, this bug causes fs.unlink() to be called when Database#load() fails in the Windows environment, but it is not deleted immediately and an EPERM error occurs.

@segayuu segayuu added the bug label May 11, 2020
@segayuu segayuu requested review from SukkaW and curbengh May 11, 2020 11:30
@segayuu segayuu merged commit 3084e84 into master May 12, 2020
@segayuu segayuu deleted the Fix-bug-resource-leak branch May 12, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants