Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): Limited @types/node version #5411

Merged
merged 1 commit into from Jan 29, 2024
Merged

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Jan 28, 2024

What does it do?

Temporarily fix #5408

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@uiolee uiolee added the dependencies Pull requests that update a dependency file label Jan 28, 2024
Copy link

How to test

git clone -b fix/type/node/version https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7684357654

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.53%

Totals Coverage Status
Change from base Build 7621654375: 0.0%
Covered Lines: 9312
Relevant Lines: 9356

💛 - Coveralls

Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but IMHO we can simply pin a specific version (the lowest Node.js version we support?).

@uiolee
Copy link
Member Author

uiolee commented Jan 29, 2024

Yes. But several of our packages use the newer types.

However that's not the point. In fact, the old version of types was wrong, and the new version of type fixes the past mistakes. I guess this PR is just a temporary fix.

@uiolee uiolee merged commit 1b569a8 into master Jan 29, 2024
18 of 22 checks passed
@uiolee uiolee deleted the fix/type/node/version branch January 29, 2024 05:54
uiolee added a commit to hexojs/hexo-fs that referenced this pull request Feb 2, 2024
uiolee added a commit to hexojs/hexo-fs that referenced this pull request Feb 2, 2024
…o 9.1.0 (#183)

* chore(deps-dev): bump c8 from 8.0.1 to 9.1.0

Bumps [c8](https://github.com/bcoe/c8) from 8.0.1 to 9.1.0.
- [Release notes](https://github.com/bcoe/c8/releases)
- [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md)
- [Commits](bcoe/c8@v8.0.1...v9.1.0)

---
updated-dependencies:
- dependency-name: c8
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps-dev): Limited @types/node version

Same as hexojs/hexo#5411

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: uiolee <22849383+uiolee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail to build hexo
3 participants