Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List hexo-canonical-link plugin #1080

Merged
merged 4 commits into from
Oct 7, 2019
Merged

List hexo-canonical-link plugin #1080

merged 4 commits into from
Oct 7, 2019

Conversation

tarunbatra
Copy link
Contributor

@tarunbatra tarunbatra commented Sep 9, 2019

Plugin to add canonical links for pages. By default, the url of the page will be set as canonical link. Other urls can be set by mentioning canonical_url in frontmatter of the page. Useful for SEO.

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)

@SukkaW
Copy link
Member

SukkaW commented Sep 9, 2019

It seems that the plugin is duplicated with hexojs/hexo#3701

@tarunbatra
Copy link
Contributor Author

@SukkaW yeah seems like that PR covers the scope of this plugin and that of hexo-auto-canonical.

@curbengh
Copy link
Contributor

Does your plugin offer any enhancement compared to hexo-auto-canonical?

@tarunbatra
Copy link
Contributor Author

Yes @curbengh, hexo-aut-canonical doesn't work for external urls and hence is opinionated. This plugin is general in nature and works for any url. I'm using this plugin to generate canonical link as seen in this page.

@curbengh
Copy link
Contributor

curbengh commented Sep 13, 2019

hexo-auto-canonical doesn't work for external urls and hence is opinionated. This plugin is general in nature and works for any url.

hexo-canonical-link readme mentions

By default, the url of the page will be set as canonical link

I assume page means the user's webpage, so is there a need to work with external urls? My understanding is that canonical meta tag is to inform the search engine which specific link (of a user's webpage) should be considered as the canonical one, so external url seems to be irrelevant, no?

Can you give a specific example where hexo-canonical-link works better?

@tarunbatra
Copy link
Contributor Author

tarunbatra commented Sep 17, 2019 via email

@curbengh
Copy link
Contributor

I see, I just read about cross-domain canonical tag. Can you mention that feature in the description? This is to let user know the difference.

also append your plugin to "plugins.yml", not prepend.

@tarunbatra
Copy link
Contributor Author

@curbengh made the changes.

@curbengh
Copy link
Contributor

Thanks, I further clarified the description.

Previously,
Set canonical link for pages with support for external links and defaults to the page url.

I don't think defaults to... is necessary for an intro. I added a comma in the middle to clarify that external link support applies to the plugin not the pages.

@NoahDragon NoahDragon merged commit 5743428 into hexojs:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants