Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1098) Add docs about escape option in post_link & asset_link helpers #1102

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

dailyrandomphoto
Copy link
Member

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)

Closes #1098
Related hexojs/hexo#3704

@curbengh curbengh added this to the v4.0.0 milestone Sep 23, 2019
source/docs/tag-plugins.md Outdated Show resolved Hide resolved
@curbengh
Copy link
Contributor

PR LGTM. But somehow How to use <b> tag in title is not escaped, maybe need to clear the netlify cache.

@curbengh curbengh mentioned this pull request Sep 23, 2019
1 task
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need workaround

source/docs/tag-plugins.md Show resolved Hide resolved
@dailyrandomphoto dailyrandomphoto force-pushed the escape-title branch 2 times, most recently from d8a4f1d to f6e1c2e Compare October 10, 2019 12:11
@dailyrandomphoto
Copy link
Member Author

@curbengh
When I generate hexojs/site project on my local, I found it takes a long time than before.
check this issue please.
hexojs/hexo#3758

@dailyrandomphoto dailyrandomphoto force-pushed the escape-title branch 2 times, most recently from 95233d2 to 3032d31 Compare October 11, 2019 07:17
@curbengh
Copy link
Contributor

curbengh commented Oct 11, 2019

😕 command = "npm install && npm run build" doesn't seem to work.

Removing package-lock.json (as what you did) looks like a good approach. But instead of removing it in every build, you can add package-lock=false line to .npmrc file. For now, it's ok to remove it, so that it's removed from the cache (cross finger on this).

Let's try .npmrc and the original netlify command = "npm run build"

@curbengh
Copy link
Contributor

command = "npm run build" still doesn't work, even with .npmrc 😞

@dailyrandomphoto
I think that's it for now, we've already caused too much inconvenience to you for debugging netlify. We'll try again with one of the functional workaround attempted here, in a separate PR. I do want to retain the .npmrc.

@dailyrandomphoto
Copy link
Member Author

Ok. thank you.

"hexo": "hexojs/hexo#commit-hash"

I think this is a reliable and reasonable approach. So we can control the version of that we want.

@curbengh
Copy link
Contributor

I'm wary of that approach as it introduce additional maintenance work.

I just had another idea,

Switch to "^4.0.0" (after its release, of course) for a while, then switch back to "hexojs/hexo".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs about escape option in post_link & asset_link helpers
3 participants