d3d12: use correct __uuidof operator #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2022
slimsag
force-pushed
the
sg/uuidof-operator
branch
from
f6ab76b
to
d72ca7e
Compare
This code uses `_uuidof` (single undescore) instead of `__uuidof` (two underscores), only the latter is documented as the officially supported operator by Microsoft: https://docs.microsoft.com/en-us/cpp/cpp/uuidof-operator?view=msvc-170 I suspect `_uuidof` and `__uuidof` are the same under the msvc compiler, but in other compilers (Zig/clang/MinGW) only the officially supported `__uuidof` is exposed. This change improves compatability with such compilers. Signed-off-by: Stephen Gutekanst <stephen@hexops.com> Change-Id: If2850a1a98507161739fcd5f52ebd4ceaefffe75
slimsag
force-pushed
the
sg/uuidof-operator
branch
from
d72ca7e
to
19c7cc5
Compare
|
CL merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pending CL being sent upstream to dawn.googlesource.com.
Status:
Helps hexops/mach#86
It appears to be a typo that
_uuidof(single underscore) was being used hereinstead of
__uuidofwhich is documented as the official operator by Microsoft:https://docs.microsoft.com/en-us/cpp/cpp/uuidof-operator?view=msvc-170
Likely
_uuidofand__uuidofare the same under msvc compilers, but Zig/clang/MinGWcompilers only expose the standard one and so this change improves compatability with
those compilers.
Signed-off-by: Stephen Gutekanst stephen@hexops.com