Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rendering into non-body DOM nodes #249

Merged
merged 4 commits into from Dec 1, 2019
Merged

Add support for rendering into non-body DOM nodes #249

merged 4 commits into from Dec 1, 2019

Commits on Dec 1, 2019

  1. Add support for rendering into non-body DOM nodes 

    This PR adds support for rendering into arbitrary DOM nodes in the same way
that rendering into the `body` worked previously, with one exception: blocking.

`RenderBody` remains blocking, since it effectively becomes a helper that 90%
of Vecty applications will rely on, whereas `RenderInto` and `RenderIntoNode`
which are introduced in this PR do not block. This is because:

a. Anyone rendering Vecty into arbitrary DOM nodes will likely want to do it
   more than once, so making the API of these functions non-blocking makes
   sense.
b. Anyone using these functions will be a more advanced user and understand
   when blocking is / is not needed.

In order to land this PR earlier for users who need this functionality, tests
will not be added. They will be added in a follow-up as part of #168.

Fixes #81
Fixes #247
    @slimsag
    slimsag committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    5066a6f View commit details
    Browse the repository at this point in the history

  2. fix tests

    @slimsag
    slimsag committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    02970fb View commit details
    Browse the repository at this point in the history

  3. fix tests / update test data

    @slimsag
    slimsag committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    87242bb View commit details
    Browse the repository at this point in the history

  4. improve panic / error naming (use correct method name always)

    @slimsag
    slimsag committed Dec 1, 2019
    Configuration menu
    Copy the full SHA
    864c5b5 View commit details
    Browse the repository at this point in the history