Allow component re-use #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I haven't had a chance to give this my full attention yet. I hope to investigate this on Sat/Sun. Overall it looks good, but I'd like to make sure there aren't any regressions, which is tough to do. I'd like to land some unit tests for this code (I've been working on those, but haven't pushed anything yet) |
|
I've pushed alternative logic for handling this, rather than jumping out of the standard loop into |
pdf
commented
May 7, 2017
Partial fix for hexops#78, only allows re-use of *vecty.Component, not *vecty.HTML
|
I've had to revert to the original implementation, as the alternative was not reliably re-rending some children. |
This was referenced May 9, 2017
Closed
|
Closing in favour of #107 meta-pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #78, only allows re-use of
*vecty.Component, not*vecty.HTML.