Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on currencies fork #59

Closed
dwilkie opened this issue May 11, 2013 · 2 comments
Closed

Remove dependency on currencies fork #59

dwilkie opened this issue May 11, 2013 · 2 comments

Comments

@dwilkie
Copy link
Contributor

dwilkie commented May 11, 2013

@hexorx I just noticed that there is still a dependency on https://github.com/dwilkie/currencies in https://github.com/hexorx/countries/blob/master/Gemfile which is probably because of this outstanding pull request hexorx/currencies#6

If you merge in hexorx/currencies#6 then bump the version, you can remove that line in the Gemfile and edit the gemspec to depend on the new version. Just cleans things up a bit
@hexorx
Copy link
Collaborator

hexorx commented May 11, 2013

Yeah I need to get on that.

@findchris
Copy link

👍

@hexorx hexorx closed this as completed Jun 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@findchris @hexorx @dwilkie