Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals to use Bundler for gem management instead of Jewler #6

Merged
merged 1 commit into from
May 11, 2013

Conversation

dwilkie
Copy link
Contributor

@dwilkie dwilkie commented May 7, 2012

@dwilkie
Copy link
Contributor Author

dwilkie commented May 7, 2012

FYI here's how you can push new versions to Ruby gems:

  1. Change the version number in lib/currencies/version.rb
  2. bundle exec rake -T # check available rake tasks
  3. bundle exec rake spec # run the tests
  4. bundle exec rake release # tags new version, builds the gem, pushes to Github and Rubygems

@hexorx
Copy link
Owner

hexorx commented May 8, 2012

First of all I appreciate your contribution. But why change it to use bundler? I have grown fond of Jeweler, it works well, and is actively maintained.

@dwilkie
Copy link
Contributor Author

dwilkie commented May 8, 2012

Hey hexorox,

The made reason I requested this change is because I was having trouble with the git-ruby gem with ruby 1.9.3-p194 which jeweler depends on: see https://rubygems.org/gems/jeweler. That Gem has not been updated for 8 months see: https://github.com/schacon/ruby-git and jeweler itself has not been updated for 4 months see: https://github.com/technicalpickles/jeweler

For me using Bundler seems much cleaner:
A) It has less dependencies (only bundler) and
B) You don't need to specify your Gemspec in your Rakefile which causes duplication and
C) The Gemspec is much smaller as it's not autogenerated

Don't take my word for it though here are some other articles who agree with me:

http://yehudakatz.com/2010/04/02/using-gemspecs-as-intended/
http://jeffkreeftmeijer.com/2010/dont-put-your-gemspec-in-your-rakefile/
http://asciicasts.com/episodes/245-new-gem-with-bundler
http://mlomnicki.com/ruby/rubygems/2011/01/22/jeweler-vs-bundler.html

@hexorx
Copy link
Owner

hexorx commented May 8, 2012

Sounds reasonable. I will read through those articles. Before merging this I want to make sure I am still able to release updates since I have always used Jeweler for my gems.

hexorx added a commit that referenced this pull request May 11, 2013
Refactor internals to use Bundler for gem management instead of Jewler
@hexorx hexorx merged commit e9df653 into hexorx:master May 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants