Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docs output if set in project's config #1026

Merged
merged 1 commit into from
May 15, 2024
Merged

Use docs output if set in project's config #1026

merged 1 commit into from
May 15, 2024

Conversation

pnezis
Copy link
Contributor

@pnezis pnezis commented May 15, 2024

Closes #1025

ericmj
ericmj approved these changes May 15, 2024
View reviewed changes
lib/mix/tasks/hex.publish.ex Outdated Show resolved Hide resolved
lib/mix/tasks/hex.publish.ex Outdated Show resolved Hide resolved
@pnezis
Copy link
Contributor Author

pnezis commented May 15, 2024

Done, added also a test that asserts that an error is raised if the output folder is missing

@ericmj ericmj requested a review from wojtekmach May 15, 2024 12:22
@wojtekmach wojtekmach merged commit f0c86ba into hexpm:main May 15, 2024
12 checks passed
@wojtekmach
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmj ericmj ericmj approved these changes

@wojtekmach wojtekmach Awaiting requested review from wojtekmach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hex.publish does not respect the docs output folder
3 participants
@pnezis @wojtekmach @ericmj