Create docs_config.js on publish #9
Conversation
It's already handled in Hexdocs.Plugs.Status
lib/hexdocs/bucket.ex
Outdated
| end | ||
|
|
||
| # TODO: don't hardcode https://hexdocs.pm, it should work on staging.hexdocs.pm too! | ||
| defp hexdocs_url("hexpm", package, version), do: "https://hexdocs.pm/#{package}/#{version}" |
There was a problem hiding this comment.
@ericmj do we already have the host somewhere or we'd need a new env variable for it? Or is there a simpler way?
There was a problem hiding this comment.
I got it, I think we can use HEXDOCS_DOCS_PUBLIC_BUCKET.
|
The only thing left here is I can't figure out why cache isn't busted when we publish docs for a release that's not gonna be the latest release. I also need to set up the redirect on vastly which will be a PR in another repo. |
lib/hexdocs/bucket.ex
Outdated
| [docs_config_js_upload_file] = | ||
| list_upload_files(repository, package, version, [docs_config_js], :unversioned) | ||
|
|
||
| upload_new_files([docs_config_js_upload_file]) |
There was a problem hiding this comment.
Include this file in paths above. Should be a little less duplicate code and we can parallelize the upload.
Is this broken currently? I would think it would have been reported already. |
Co-Authored-By: wojtekmach <wojtekmach@users.noreply.github.com>
No description provided.