-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docs_config.js for Elixir, ExDoc, Hex etc #30
Comments
Is this issue about adding the Is it also about fixing the links to Elixir v1.0.0 - v1.0.3 or is it a separate issue? |
I think we should add We don't have docs builds for Elixir v1.0.0 - v1.0.3 so we should remove those links from the dropdown. |
I actually initially had master in the dropdown (5d2fc6b) but then on https://hexdocs.pm/elixir/master/Kernel.html page the dropdown had both 1.9.0-dev and master which was confusing. When building config I could see that the latest tag is v1.8.1 so the next dev version should be v1.9.0-dev and put that into the list with the link to master, but I'm afraid this could be too clever and error prone. I've removed links for 1.0.0..1.0.3, good catch! |
This will be fine for a long long long time, at least until we start work on v2.0, so I am ok with it. |
@josevalim just so we're clear, you're saying to add 1.9.0-dev (or whatever the latest dev version is) to the config.js or leave things as is? |
@wojtekmach I see. You can take a look at my code here - for people hosting their docs and maintaining their own versions, for convenience and so that things don't break, we're prepending the list with an entry for the current version if it's seemingly missing. The current version name is being read from what was displayed instead of the version dropdown, so indeed for the current master it's v1.9.0-dev. Looks like having an option v1.9.0-dev is the easy way to go for now, I actually don't mind if it would be called that. We could change my code in ExDoc if we want to display |
This. :) |
Ref: hexpm/hexdocs#9
The text was updated successfully, but these errors were encountered: