Remove package ownerships when removing organization member

[ericmj]

This is only a clean up since we always check organization membership when checking package permissions.

To clean up existing membership:

# DELETE
SELECT o.name, p.name, u.username
FROM package_owners AS po
JOIN packages AS p ON po.package_id = p.id
JOIN users AS u ON po.user_id = u.id
JOIN repositories AS r ON p.repository_id = r.id
JOIN organizations AS o ON r.organization_id = o.id
WHERE o.id != 1
  AND o.id NOT IN (SELECT id FROM organization_users WHERE organization_id = o.id);

[sourcelevel-bot]

SourceLevel has finished reviewing this Pull Request and has found:

• 1 fixed issue! 🎉

See more details about this review.

[supersimple]

🌯 💯 🐱

[supersimple]

I always get confused as to when to use fetch, and when to use compile. Any tips for me?

[wojtekmach]

use compile_env at compile-time 😎 (such as exactly here!)

[wojtekmach]

to expand,

# foo.ex

# this is compile-time
Application.compile_env(:foo, :bar)

defmodule Foo do
  # this is compile-time too
  Application.compile_env(:foo, :bar)

  def foo do
    # this is runtime
    Application.fetch_env(:foo, :bar)

    # inside unquote, we're at compile-time
    unquote(Application.compile_env(:foo, :bar))
  end

  defmacro deffoo do
    # this is compile-time too
    Application.compile_env(:foo, :bar)
    
    quote do
      # this is... it depends how we use the macro. If we use it in module body
      # we'd use compile_env here. If we use the macro inside def, we'd use fetch_env.
    end
  end
end

hope it makes sense and is useful!