HEX-561: Add sort by recent downloads feature #566

jeramyRR · 2017-09-02T16:12:13Z

Add new ninety_days view to package_downloads view
Add new migration to drop and reinsert package_downloads MATERIALIZED
VIEW
Add ninety_days sort to package.ex
Add function to query db for all views within a list of packages in
package_download.ex
Update default sorting to ninety_days in: package_controller,
layout/header.html.eex, opensearch.xml.eex, page/index.html.eex
Update OpenSearchController test to include ninety_days sort by default
change
Update :downloads atom to :total_downloads
Add tooltip to downloads info css
Update _package.html.eex template to display appropriate downloads desc
text for current sort method
Update _package.html.eex template to display a tooltip, when hovering
over downloads desc text, with either total downloads or recent
downloads depending upon sort method
Update show_sort_info functions to include sort by changes (i.e. total
downloads or ninety_days). This update fixed a bug where the
show_sort_info wasn't displaying the text as the functions expected a
string while the actual input was coming in as an atom
Update PackageViewTest to reflect show sort info changes
Update seed.exs with inclusions of ninety_day downloads for packages:
decimal, ecto, postgrex, and ups packages
Update package_test.exs to include :total_downloads sort change

Add new ninety_days view to package_downloads view Add new migration to drop and reinsert package_downloads MATERIALIZED VIEW Add ninety_days sort to package.ex Add function to query db for all views within a list of packages in package_download.ex Update default sorting to ninety_days in: package_controller, layout/header.html.eex, opensearch.xml.eex, page/index.html.eex Update OpenSearchController test to include ninety_days sort by default change Update :downloads atom to :total_downloads Add tooltip to downloads info css Update _package.html.eex template to display appropriate downloads desc text for current sort method Update _package.html.eex template to display a tooltip, when hovering over downloads desc text, with either total downloads or recent downloads depending upon sort method Update show_sort_info functions to include sort by changes (i.e. total downloads or ninety_days). This update fixed a bug where the show_sort_info wasn't displaying the text as the functions expected a string while the actual input was coming in as an atom Update PackageViewTest to reflect show sort info changes Update seed.exs with inclusions of ninety_day downloads for packages: decimal, ecto, postgrex, and ups packages Update package_test.exs to include :total_downloads sort change

sourcelevel-bot · 2017-09-02T16:12:15Z

Hello, @jeramyRR! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

sourcelevel-bot · 2017-09-02T16:12:58Z

assets/css/template/_package-list.scss

+          -webkit-transition: all 0.2s ease;
+          -moz-transition: all 0.2s ease;
+          -o-transition: all 0.2s ease;
+          transition: all 0.2s ease;


0.2 should be written without a leading zero as .2

Read more about it here.

sourcelevel-bot · 2017-09-02T16:12:59Z

assets/css/template/_package-list.scss

+          top: 1.2em;
+          -webkit-transition: all 0.2s ease;
+          -moz-transition: all 0.2s ease;
+          -o-transition: all 0.2s ease;


0.2 should be written without a leading zero as .2

Read more about it here.

sourcelevel-bot · 2017-09-02T16:12:59Z

assets/css/template/_package-list.scss

+          top: 1.2em;
+          -webkit-transition: all 0.2s ease;
+          -moz-transition: all 0.2s ease;
+          -o-transition: all 0.2s ease;


Avoid vendor prefixes.

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:00Z

assets/css/template/_package-list.scss

+          visibility: visible;
+          top: 1.2em;
+          -webkit-transition: all 0.2s ease;
+          -moz-transition: all 0.2s ease;


0.2 should be written without a leading zero as .2

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:00Z

assets/css/template/_package-list.scss

+          visibility: visible;
+          top: 1.2em;
+          -webkit-transition: all 0.2s ease;
+          -moz-transition: all 0.2s ease;


Avoid vendor prefixes.

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:00Z

assets/css/template/_package-list.scss

+        .downloads-count-wrapper:hover .tooltiptext {
+          visibility: visible;
+          top: 1.2em;
+          -webkit-transition: all 0.2s ease;


0.2 should be written without a leading zero as .2

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:01Z

assets/css/template/_package-list.scss

+        .downloads-count-wrapper:hover .tooltiptext {
+          visibility: visible;
+          top: 1.2em;
+          -webkit-transition: all 0.2s ease;


Avoid vendor prefixes.

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:01Z

assets/css/template/_package-list.scss

+          }
+        }
+        .downloads-count-wrapper:hover .tooltiptext {
+          visibility: visible;


Properties should be ordered top, visibility, transition

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:02Z

assets/css/template/_package-list.scss

+            transition: all 0.3s ease-in-out;
+          }
+        }
+        .downloads-count-wrapper:hover .tooltiptext {


Selector should have depth of applicability no greater than 4, but was 6.

Nested selectors are highly coupled to the DOM structure, they will produce less efficient selectors and they compromises the readability of your code although it reduces the duplication of parent selectors. It is recommended to follow the inception rule in such scenarios.

You can reduce this nesting by introducing new selectors targeting the nested elements instead of relying in their parent / child dependency.

sourcelevel-bot · 2017-09-02T16:13:02Z

assets/css/template/_package-list.scss

+            -o-transition: all 0.3s ease;
+            transition: all 0.3s ease-in-out;
+          }
+        }


Rule declaration should be followed by an empty line

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:02Z

assets/css/template/_package-list.scss

+            -webkit-transition: all 0.3s ease;
+            -moz-transition: all 0.3s ease-in-out;
+            -o-transition: all 0.3s ease;
+            transition: all 0.3s ease-in-out;


0.3 should be written without a leading zero as .3

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:03Z

assets/css/template/_package-list.scss

+            text-transform: none;
+            -webkit-transition: all 0.3s ease;
+            -moz-transition: all 0.3s ease-in-out;
+            -o-transition: all 0.3s ease;


0.3 should be written without a leading zero as .3

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:03Z

assets/css/template/_package-list.scss

+            text-transform: none;
+            -webkit-transition: all 0.3s ease;
+            -moz-transition: all 0.3s ease-in-out;
+            -o-transition: all 0.3s ease;


Avoid vendor prefixes.

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:04Z

assets/css/template/_package-list.scss

+            top: -2em;
+            text-transform: none;
+            -webkit-transition: all 0.3s ease;
+            -moz-transition: all 0.3s ease-in-out;


0.3 should be written without a leading zero as .3

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:04Z

assets/css/template/_package-list.scss

+            top: -2em;
+            text-transform: none;
+            -webkit-transition: all 0.3s ease;
+            -moz-transition: all 0.3s ease-in-out;


Avoid vendor prefixes.

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:04Z

assets/css/template/_package-list.scss

+            position: relative;
+            top: -2em;
+            text-transform: none;
+            -webkit-transition: all 0.3s ease;


0.3 should be written without a leading zero as .3

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:04Z

assets/css/template/_package-list.scss

+            position: relative;
+            top: -2em;
+            text-transform: none;
+            -webkit-transition: all 0.3s ease;


Avoid vendor prefixes.

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:05Z

assets/css/template/_package-list.scss

+            text-align: center;
+            border-radius: 4px;
+            border: #919ca2 1px solid;
+            padding: 5px 5px;


Shorthand form for property padding should be written more concisely as 5px instead of 5px 5px

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:05Z

assets/css/template/_package-list.scss

+          }
+          .tooltiptext {
+            @include font-size(14, $base-line-height);
+            visibility: hidden;


Properties should be ordered position, top, width, padding, color, text-align, text-transform, visibility, background-color, border, border-radius, transition

Read more about it here.

sourcelevel-bot · 2017-09-02T16:13:05Z

assets/css/template/_package-list.scss

+          .downloads-count-desc {
+            border-bottom: 1px dotted $color-purple;
+          }
+          .tooltiptext {


Selector should have depth of applicability no greater than 4, but was 6.

Nested selectors are highly coupled to the DOM structure, they will produce less efficient selectors and they compromises the readability of your code although it reduces the duplication of parent selectors. It is recommended to follow the inception rule in such scenarios.

You can reduce this nesting by introducing new selectors targeting the nested elements instead of relying in their parent / child dependency.

sourcelevel-bot · 2017-09-02T16:19:35Z

assets/css/template/_package-list.scss

}
+

Line contains trailing whitespace

Read more about it here.

sourcelevel-bot · 2017-09-02T16:19:35Z

assets/css/template/_package-list.scss

+          }
+        }
+
+        .downloads-count-wrapper:hover .tooltiptext {


Selector should have depth of applicability no greater than 4, but was 6.

Nested selectors are highly coupled to the DOM structure, they will produce less efficient selectors and they compromises the readability of your code although it reduces the duplication of parent selectors. It is recommended to follow the inception rule in such scenarios.

You can reduce this nesting by introducing new selectors targeting the nested elements instead of relying in their parent / child dependency.

sourcelevel-bot · 2017-09-02T16:19:36Z

assets/css/template/_package-list.scss

+
+          .downloads-count-desc {
+            border-bottom: 1px dotted $color-purple;
+          }


Rule declaration should be followed by an empty line

Read more about it here.

sourcelevel-bot · 2017-09-02T16:19:36Z

assets/css/template/_package-list.scss

+          position: relative;
+          display: inline-block;
+
+          .downloads-count-desc {


Selector should have depth of applicability no greater than 4, but was 6.

Nested selectors are highly coupled to the DOM structure, they will produce less efficient selectors and they compromises the readability of your code although it reduces the duplication of parent selectors. It is recommended to follow the inception rule in such scenarios.

You can reduce this nesting by introducing new selectors targeting the nested elements instead of relying in their parent / child dependency.

sourcelevel-bot · 2017-09-02T16:19:36Z

assets/css/template/_package-list.scss

@@ -93,8 +93,40 @@
          font-weight: bold;
          color: $color-text-grey;
        }
+        .downloads-count-wrapper {


Selector should have depth of applicability no greater than 4, but was 5.

Nested selectors are highly coupled to the DOM structure, they will produce less efficient selectors and they compromises the readability of your code although it reduces the duplication of parent selectors. It is recommended to follow the inception rule in such scenarios.

You can reduce this nesting by introducing new selectors targeting the nested elements instead of relying in their parent / child dependency.

sourcelevel-bot · 2017-09-02T16:19:37Z

test/hexpm/repository/package_test.exs

+    assert [^phoenix_id, ^ecto_id] = Package.all([repository], 1, 10, nil, :total_downloads, nil) |> Repo.pluck(:id)
+  end
+
+


There should be no more than 1 consecutive blank lines.

sourcelevel-bot · 2017-09-02T16:19:37Z

lib/hexpm/web/views/package_view.ex

+    Map.get(downloads, package.id, %{"all" => 0, "ninety_days" => 0})
+  end
+
+


There should be no more than 1 consecutive blank lines.

sourcelevel-bot · 2017-09-02T16:19:38Z

lib/hexpm/repository/packages.ex

+    |> Repo.all()
+    |> Enum.into([])
+    |> Enum.reduce(%{}, fn(package, acc) ->
+      { id, view, dls } = package


There is no whitespace around parentheses/brackets most of the time, but here there is.

sourcelevel-bot · 2017-09-02T16:19:38Z

lib/hexpm/repository/packages.ex

+                |> Map.put(view, dls)
+          Map.update!(acc, id, fn(_) -> map end)
+        false ->
+          Map.put_new(acc, id,  %{ view => dls })


There is no whitespace around parentheses/brackets most of the time, but here there is.

sourcelevel-bot · 2017-09-02T16:19:39Z

lib/hexpm/repository/package.ex

+      order_by: [fragment("? DESC NULLS LAST", d.downloads)])
+  end
+
+


There should be no more than 1 consecutive blank lines.

sourcelevel-bot · 2017-09-02T16:35:14Z

assets/css/template/_package-list.scss

@@ -93,8 +93,43 @@
          font-weight: bold;
          color: $color-text-grey;
        }
+
+        .downloads-count-wrapper {


Selector should have depth of applicability no greater than 4, but was 5.

Nested selectors are highly coupled to the DOM structure, they will produce less efficient selectors and they compromises the readability of your code although it reduces the duplication of parent selectors. It is recommended to follow the inception rule in such scenarios.

You can reduce this nesting by introducing new selectors targeting the nested elements instead of relying in their parent / child dependency.

ericmj · 2017-09-02T20:42:23Z

lib/hexpm/web/controllers/package_controller.ex

@@ -2,7 +2,7 @@ defmodule Hexpm.Web.PackageController do
  use Hexpm.Web, :controller

  @packages_per_page 30
-  @sort_params ~w(name downloads inserted_at updated_at)
+  @sort_params ~w(name ninety_days total_downloads inserted_at updated_at)


ninety_days is fine for internal use, but lets call it recent_downloads and total_downloads for users.

Updated to recent_downloads.

ericmj · 2017-09-02T20:46:21Z

lib/hexpm/repository/packages.ex

+  def packages_downloads_with_all_views(packages) do
+    PackageDownload.packages_and_all_download_views(packages)
+    |> Repo.all()
+    |> Enum.into([])


Repo.all() already returns a list.

Removed unnecessary Enum.into.

ericmj · 2017-09-02T20:52:39Z

lib/hexpm/repository/packages.ex

+    |> Enum.into([])
+    |> Enum.reduce(%{}, fn(package, acc) ->
+      {id, view, dls} = package
+      case Map.has_key?(acc, id) do


Using Map.update/4 should simplify this.

Thanks! Using Map.update/4 reduced this peace into two or three lines.

ericmj · 2017-09-02T20:53:05Z

lib/hexpm/repository/package_download.ex

+      join: p in assoc(pd, :package),
+      where: pd.package_id in ^package_ids,
+      select: {p.id, pd.view, coalesce(pd.downloads, 0)},
+      order_by: [desc: pd.view])


order_by is not needed since we will put it in a map later, right?

Removed order_by.

ericmj · 2017-09-02T20:53:29Z

lib/hexpm/web/templates/package/_package.html.eex

+    <div class="downloads-count-wrapper">
+      <span class="downloads-count-desc"><%= display_downloads_view_title(@view) %></span><br>
+      <span class="tooltiptext"><%= display_downloads_for_opposite_views(@package_downloads, @view) %></span>
+    </div>


Can you show screenshots of the UI changes?

Added below.

jeramyRR · 2017-09-03T00:58:08Z

jeramyRR · 2017-09-03T01:05:07Z

Remove order_by from packages_and_all_download_views function Simplify the Map.update in packages_downloads_with_all_views function

sourcelevel-bot · 2017-09-03T01:29:35Z

lib/hexpm/web/views/package_view.ex

+
+  def display_downloads(package_downloads, view) do
+    case view do
+      :recent_downloads->


There are spaces around operators most of the time, but not here.

sourcelevel-bot · 2017-09-03T01:29:36Z

lib/hexpm/web/views/package_view.ex

+
+  def display_downloads_for_opposite_views(package_downloads, view) do
+    case view do
+      :recent_downloads->


There are spaces around operators most of the time, but not here.

sourcelevel-bot · 2017-09-03T01:29:36Z

lib/hexpm/web/views/package_view.ex

+
+  def display_downloads_view_title(view) do
+    case view do
+      :recent_downloads-> "recent downloads"


There are spaces around operators most of the time, but not here.

jeramyRR · 2017-09-03T01:32:04Z

I still have to figure out how to properly create a test method for this. The current one is just a copy paste, and it's failing.

Update package_view_test and opensearch_controller_test to reflect ninety_days to recent_downloads change

ericmj

I added a few minor comments but this looks good to me.

ericmj · 2017-09-07T14:54:32Z

lib/hexpm/repository/packages.ex

+    The return value is a map with the following structure:
+    %{ package.id => %{ view1 => numDownloads, view2 => numDownloads, ...}
+    Example: %{ 105 => %{ "all" => 1_234_567, "recent" => 10_000, etc... }
+  """


We generally do not add docs here.

ericmj · 2017-09-07T14:55:01Z

lib/hexpm/web/controllers/api/package_controller.ex


  def index(conn, params) do
    # TODO: Handle /repos/:repo/ and /
    repositories = Users.all_repositories(conn.assigns.current_user)
    page = Hexpm.Utils.safe_int(params["page"])
    search = Hexpm.Utils.parse_search(params["search"])
-    sort = Hexpm.Utils.safe_to_atom(params["sort"] || "name", @sort_params)
+    sort = Hexpm.Utils.safe_to_atom(params["sort"] || "recent_downloads", @sort_params)


I don't think we should change the default sorting here.

ericmj · 2017-09-07T14:55:15Z

lib/hexpm/web/controllers/package_controller.ex

+    sort params:
+    recent_downloads is defined as the sum of a packages downloads over ninety days.
+    total_downloads is the sum of all a packages downloads.
+  """


No docs here either.

ericmj · 2017-09-07T14:55:58Z

lib/hexpm/web/controllers/package_controller.ex

@@ -20,12 +26,12 @@ defmodule Hexpm.Web.PackageController do
      end

    repositories = Users.all_repositories(conn.assigns.current_user)
-    sort = Hexpm.Utils.safe_to_atom(params["sort"] || "name", @sort_params)
+    sort = Hexpm.Utils.safe_to_atom(params["sort"] || "recent_downloads", @sort_params)


Changing the default here is fine 👍

ericmj · 2017-09-07T14:56:25Z

lib/hexpm/web/controllers/package_controller.ex

@@ -89,7 +95,7 @@ defmodule Hexpm.Web.PackageController do

    downloads = Packages.package_downloads(package)
    owners = Owners.all(package, [:emails])
-    dependants = Packages.search(repositories, 1, 20, "depends:#{package.name}", :downloads, [:name, :repository_id])
+    dependants = Packages.search(repositories, 1, 20, "depends:#{package.name}", :total_downloads, [:name, :repository_id])


Use recent_downloads here imo.

ericmj · 2017-09-07T14:56:34Z

lib/hexpm/web/templates/layout/header.html.eex

@@ -37,7 +37,7 @@
          <form class="navbar-form pull-left" role="search" action="<%= package_path(Endpoint, :index) %>">
             <div class="input-group">
                <input placeholder="Find packages" name="search" type="text" autofocus class="form-control" value="<%= search(assigns) %>">
-                <input type="hidden" name="sort" value="downloads">
+                <input type="hidden" name="sort" value="recent_downloads">


Remove docs from packages.ex and package_controller.ex Return default sort of api/package_controller to name Update default sort of dependants to recent_downloads to match package default sort

jeramyRR · 2017-09-08T01:39:10Z

Pushed a new commit up to address your comments.

wojtekmach · 2017-09-08T23:26:09Z

Thank you, this is a really good improvement!

jeramyRR · 2017-09-08T23:51:19Z

Thanks, and thanks for letting me work the feature. This was my first open source contribution, as well as pretty much my first serious Elixir thing, even though it was really small.

ericmj · 2017-09-09T00:01:28Z

I just deployed this and I love it already. Thank you @jeramyRR.

sourcelevel-bot bot reviewed Sep 2, 2017

View reviewed changes

HEX-561: Address ebert automated review findings

4220a3d

sourcelevel-bot bot reviewed Sep 2, 2017

View reviewed changes

assets/css/template/_package-list.scss Outdated

}

Copy link

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

Read more about it here.

sourcelevel-bot bot reviewed Sep 2, 2017

View reviewed changes

jeramyRR added 2 commits September 2, 2017 11:23

HEX-561: Address ebert automated comments part 2

6de9c74

HEX-561: Address credo and scss lint comments

167fd90

sourcelevel-bot bot reviewed Sep 2, 2017

View reviewed changes

ericmj reviewed Sep 2, 2017

View reviewed changes

HEX-561: Change ninety_days to recent/recent_downloads

c54fd72

Remove order_by from packages_and_all_download_views function Simplify the Map.update in packages_downloads_with_all_views function

sourcelevel-bot bot reviewed Sep 3, 2017

View reviewed changes

jeramyRR added 2 commits September 2, 2017 20:33

HEX-561: Add space between atom and ->

76b2d4f

HEX-561: Update sort packages by recent downloads test properly

cd9b840

Update package_view_test and opensearch_controller_test to reflect ninety_days to recent_downloads change

jeramyRR mentioned this pull request Sep 3, 2017

Search results displays packages based off number of downloads recently #561

Closed

ericmj approved these changes Sep 7, 2017

View reviewed changes

HEX-561: Address PR review concerns

84ea553

Remove docs from packages.ex and package_controller.ex Return default sort of api/package_controller to name Update default sort of dependants to recent_downloads to match package default sort

wojtekmach merged commit 556f154 into hexpm:master Sep 8, 2017

		assert [^phoenix_id, ^ecto_id] = Package.all([repository], 1, 10, nil, :total_downloads, nil) \|> Repo.pluck(:id)
		end

		Map.get(downloads, package.id, %{"all" => 0, "ninety_days" => 0})
		end

HEX-561: Add sort by recent downloads feature #566

HEX-561: Add sort by recent downloads feature #566

Conversation

jeramyRR commented Sep 2, 2017

sourcelevel-bot bot commented Sep 2, 2017

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

sourcelevel-bot bot Sep 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeramyRR commented Sep 3, 2017

jeramyRR commented Sep 3, 2017

sourcelevel-bot bot Sep 3, 2017