Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: negative numbers in numeric enums #470

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #466

Copy link

codesandbox bot commented Apr 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 520318f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 11:50pm

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.74%. Comparing base (dfad425) to head (520318f).

Files Patch % Lines
packages/openapi-ts/src/compiler/typedef.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   79.70%   79.74%   +0.04%     
==========================================
  Files          75       75              
  Lines        6026     6029       +3     
  Branches      603      603              
==========================================
+ Hits         4803     4808       +5     
+ Misses       1222     1220       -2     
  Partials        1        1              
Flag Coverage Δ
unittests 79.74% <85.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit ab68dfa into main Apr 23, 2024
16 checks passed
@jordanshatford jordanshatford deleted the fix/negative-enum-numeric-values branch April 23, 2024 05:40
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants