Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove enum postfix, use typescript enums in types when generated, export enums from types.gen.ts #498

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 26, 2024

Closes #398
Closes #491

Copy link

stackblitz bot commented Apr 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 59343f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/openapi-ts Minor
@hey-api/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 10:49pm

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.65%. Comparing base (2c0d370) to head (59343f1).

Files Patch % Lines
packages/openapi-ts/src/utils/write/types.ts 45.45% 6 Missing ⚠️
packages/openapi-ts/src/utils/enum.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   79.68%   79.65%   -0.04%     
==========================================
  Files          75       75              
  Lines        6089     6070      -19     
  Branches      611      608       -3     
==========================================
- Hits         4852     4835      -17     
+ Misses       1236     1234       -2     
  Partials        1        1              
Flag Coverage Δ
unittests 79.65% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos marked this pull request as ready for review April 26, 2024 22:48
@mrlubos mrlubos merged commit 0ca8b75 into main Apr 26, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/typescript-enums branch April 26, 2024 22:56
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enums are suffixed with Enum? TypeScript Enum Support on Models in 0.39.0
2 participants