Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

fix: safari flex gap #270

Closed
wants to merge 1 commit into from
Closed

fix: safari flex gap #270

wants to merge 1 commit into from

Conversation

Simplyalex99
Copy link
Contributor

Adjusted gap-12 property with gap-8 and added space-x-2 property which is supported on multiple browsers.

Copy link
Contributor

@HenryLeC HenryLeC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ty

@HenryLeC
Copy link
Contributor

I mill merge once @heybereket reviews

Copy link
Contributor

@alexover1 alexover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using gap-8 and space-x-2? If gap-8 doesn't work on all browsers why not just use like a bigger space-x?

@Simplyalex99
Copy link
Contributor Author

Hey alexover1, yes you are correct. I thought I leave the gap property so that for chrome and browsers that do support it, it will be more spacious. But that can be changed and will work just as fine too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants