Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new syntax for DOMException. #780

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented Aug 29, 2019

See #778.


💥 Error: 400 Bad Request 💥

PR Preview failed to build. (Last tried on Aug 29, 2019, 9:04 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

Error running preprocessor, returned code: 1.
WARNING: Multiple elements have the same ID 'w3c_process_revision'.
Deduping, but this ID may not be stable across revisions.
Traceback (most recent call last):
  File "/sites/api.csswg.org/bikeshed/bikeshed.py", line 5, in 
    bikeshed.main()
  File "/sites/api.csswg.org/bikeshed/bikeshed/cli.py", line 205, in main
    handleSpec(options, extras)
  File "/sites/api.csswg.org/bikeshed/bikeshed/cli.py", line 241, in handleSpec
    doc.preprocess()
  File "/sites/api.csswg.org/bikeshed/bikeshed/Spec.py", line 103, in preprocess
    self.processDocument()
  File "/sites/api.csswg.org/bikeshed/bikeshed/Spec.py", line 186, in processDocument
    idl.markupIDL(self)
  File "/sites/api.csswg.org/bikeshed/bikeshed/idl.py", line 231, in markupIDL
    replaceContents(el, parseHTML(unicode(widl.markup(marker))))
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/parser.py", line 280, in markup
    return generator.markup(marker)
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 164, in markup
    head, tail = marker.markupName(self.text, construct) if (hasattr(marker, 'markupName')) else (None, None)
  File "/sites/api.csswg.org/bikeshed/bikeshed/idl.py", line 168, in markupName
    methodNames = ["{0}/{1}".format(interfaceName, m) for m in construct.parent.methodNames]
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/productions.py", line 1799, in methodNames
    return [_name(self) + '(' + argumentName + ')' for argumentName in self.arguments.argumentNames]
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@bzbarsky bzbarsky merged commit 21ffd9b into master Aug 29, 2019
@annevk
Copy link
Member

annevk commented Aug 29, 2019

I don't think you should have landed this as there's no tooling support for this...

@bzbarsky
Copy link
Collaborator

Hmm. Is the IDL in question actually being ingested by other tools? If so, we need to revert this for now, yes.

@annevk
Copy link
Member

annevk commented Aug 29, 2019

Well, yes, Web IDL is written in bikeshed, which does a bunch of processing on it using widlparser. (This is why I think we should have changes for those lined up as well before we approve syntax changes as there tends be quite a bit of confusion afterwards when that's not done.)

@annevk
Copy link
Member

annevk commented Aug 29, 2019

And also, the tools scraping specifications for IDL to put it into web-platform-tests are also not updated yet I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants