Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use new syntax for DOMException." #781

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

bzbarsky
Copy link
Collaborator

@bzbarsky bzbarsky commented Aug 29, 2019

Reverts #780 for now until the tooling is ready.


💥 Error: 400 Bad Request 💥

PR Preview failed to build. (Last tried on Aug 29, 2019, 3:25 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

Error running preprocessor, returned code: 1.
WARNING: Multiple elements have the same ID 'w3c_process_revision'.
Deduping, but this ID may not be stable across revisions.
Traceback (most recent call last):
  File "/sites/api.csswg.org/bikeshed/bikeshed.py", line 5, in 
    bikeshed.main()
  File "/sites/api.csswg.org/bikeshed/bikeshed/cli.py", line 205, in main
    handleSpec(options, extras)
  File "/sites/api.csswg.org/bikeshed/bikeshed/cli.py", line 241, in handleSpec
    doc.preprocess()
  File "/sites/api.csswg.org/bikeshed/bikeshed/Spec.py", line 103, in preprocess
    self.processDocument()
  File "/sites/api.csswg.org/bikeshed/bikeshed/Spec.py", line 186, in processDocument
    idl.markupIDL(self)
  File "/sites/api.csswg.org/bikeshed/bikeshed/idl.py", line 231, in markupIDL
    replaceContents(el, parseHTML(unicode(widl.markup(marker))))
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/parser.py", line 280, in markup
    return generator.markup(marker)
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 81, in markup
    output += u''.join([child.markup(marker, self.construct) for child in self.children])
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/markup.py", line 164, in markup
    head, tail = marker.markupName(self.text, construct) if (hasattr(marker, 'markupName')) else (None, None)
  File "/sites/api.csswg.org/bikeshed/bikeshed/idl.py", line 168, in markupName
    methodNames = ["{0}/{1}".format(interfaceName, m) for m in construct.parent.methodNames]
  File "/sites/api.csswg.org/bikeshed/bikeshed/widlparser/widlparser/productions.py", line 1799, in methodNames
    return [_name(self) + '(' + argumentName + ')' for argumentName in self.arguments.argumentNames]
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@bzbarsky bzbarsky requested a review from annevk August 29, 2019 15:25
@Ms2ger
Copy link
Member

Ms2ger commented Aug 29, 2019

I'd prefer to wait until, say, Tuesday morning. If the tooling hasn't caught up by then, I'd be happy to land this.

@bzbarsky
Copy link
Collaborator Author

That works for me, as long as in the interim this is not causing specs to not get rendered or something.

@annevk annevk requested review from Ms2ger and removed request for annevk August 30, 2019 07:13
@annevk
Copy link
Member

annevk commented Aug 30, 2019

It seems like IDL continues to render the 27 August version, which is fine.

@foolip
Copy link
Member

foolip commented Aug 30, 2019

tabatkins/bikeshed-tests#9 broke because of this too.

Blocked on speced/bikeshed#1513.

@foolip
Copy link
Member

foolip commented Aug 30, 2019

That in turn is blocked on plinss/widlparser#47 which I can't figure out, so I'd recommend landing this so that @plinss and @tabatkins don't have to rush to fix that next week.

@Ms2ger Ms2ger merged commit 182b487 into master Sep 3, 2019
@Ms2ger Ms2ger deleted the revert-780-constructor-domexception branch September 3, 2019 07:08
@foolip
Copy link
Member

foolip commented Sep 3, 2019

Alright, https://heycam.github.io/webidl/ successfully built and published again. So to reland this Bikeshed still needs to roll widlparser, speced/bikeshed#1514.

Retrying bikeshed-tests in https://travis-ci.com/foolip/bikeshed-tests/builds/125550850.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants