-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added web support #98
Conversation
Nice work @YajanaRao ! Did you test it on mobile as well? Make sure it works? |
Something wrong with my android setup. I will try and update in sometime. |
@YajanaRao You have a bunch of lint and typescript errors. Can you please fix them :) |
@watadarkstar Updated the code based on review comments. |
…husky-pre-commit-hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems like a lot of changes in the yarn.lock file. I just want to test this and make sure its not over changing anything.
@watadarkstar Let me know if any changes required from my side ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YajanaRao Btw I got Netlify CI working for web now. Thanks for this! |
Description
Addresses issue #10
Ticket Link
#10
How has this been tested?
Tested on web
![image](https://user-images.githubusercontent.com/38914337/136082944-5d5fd397-1435-4505-ac94-fbef7ef3e9da.png)
Screenshots
Checklist