Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added web support #98

Merged
merged 8 commits into from
Oct 9, 2021
Merged

Added web support #98

merged 8 commits into from
Oct 9, 2021

Conversation

YajanaRao
Copy link
Contributor

@YajanaRao YajanaRao commented Oct 5, 2021 •
edited

Description

Addresses issue #10

Ticket Link

#10

How has this been tested?

Tested on web
image

Screenshots

Checklist

  • Added a "Closes [issue number]" in the ticket link section
  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens

@YajanaRao YajanaRao changed the title Husky pre commit hook Added web support Oct 5, 2021
@watadarkstar
Copy link
Collaborator

Nice work @YajanaRao ! Did you test it on mobile as well? Make sure it works?

@YajanaRao
Copy link
Contributor Author

Something wrong with my android setup. I will try and update in sometime.

@watadarkstar
Copy link
Collaborator

@YajanaRao You have a bunch of lint and typescript errors. Can you please fix them :)

watadarkstar
watadarkstar reviewed Oct 5, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
watadarkstar
watadarkstar reviewed Oct 5, 2021
View reviewed changes
hooks/useFiles.web.ts Outdated Show resolved Hide resolved
@YajanaRao
Copy link
Contributor Author

@watadarkstar Updated the code based on review comments.

watadarkstar
watadarkstar reviewed Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@watadarkstar watadarkstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems like a lot of changes in the yarn.lock file. I just want to test this and make sure its not over changing anything.

@YajanaRao
Copy link
Contributor Author

@watadarkstar Let me know if any changes required from my side ?

@frubesss frubesss mentioned this pull request Oct 9, 2021
Closed
watadarkstar
watadarkstar approved these changes Oct 9, 2021
View reviewed changes
Copy link
Collaborator

@watadarkstar watadarkstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watadarkstar watadarkstar merged commit 107df8f into heylinda:main Oct 9, 2021
@watadarkstar watadarkstar mentioned this pull request Oct 9, 2021
Closed
@watadarkstar
Copy link
Collaborator

@YajanaRao Btw I got Netlify CI working for web now. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watadarkstar watadarkstar watadarkstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YajanaRao @watadarkstar