feat: use biome

heyxyz · Dec 12, 2023 · 7cfd399 · 7cfd399
1 parent fb17055
commit 7cfd399
Show file tree

Hide file tree

Showing 35 changed files with 2,149 additions and 2,260 deletions.
diff --git a/.deepsource.toml b/.deepsource.toml
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -35,8 +35,8 @@ jobs:
       - name: Lint 🪩
         run: pnpm lint:affected
 
-      - name: Prettier ✨
-        run: pnpm prettier:affected
+      - name: Biome ✨
+        run: pnpm biome:affected
 
       - name: Build 🎁
         run: pnpm build

diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -2,4 +2,5 @@
 . "$(dirname "$0")/_/husky.sh"
 
 pnpm lint:affected
+pnpm biome:affected
 pnpm typecheck:affected
diff --git a/.prettierignore b/.prettierignore
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,3 +1,10 @@
 {
-  "editor.tabSize": 2
+  "editor.tabSize": 2,
+  "[javascript]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "editor.formatOnSave": true,
+  "editor.codeActionsOnSave": {
+    "quickfix.biome": "always"
+  }
 }
diff --git a/apps/api/.prettierignore b/apps/api/.prettierignore
diff --git a/apps/api/package.json b/apps/api/package.json
@@ -11,8 +11,8 @@
     "postinstall": "pnpm codegen",
     "lint": "eslint . --ext .js,.ts,.tsx",
     "lint:fix": "eslint . --fix --ext .js,.ts,.tsx",
-    "prettier": "prettier --check \"**/*.{js,ts,tsx,md}\"  --cache",
-    "prettier:fix": "prettier --write \"**/*.{js,ts,tsx,md}\"  --cache",
+    "biome": "biome check *",
+    "biome:fix": "biome check * --apply",
     "prisma:format": "prisma format --schema ./src/db/schema.prisma",
     "prisma:migrate": "prisma migrate dev --schema ./src/db/schema.prisma",
     "prisma:studio": "prisma studio --schema ./src/db/schema.prisma",

diff --git a/apps/api/src/routes/stats/profileDetails.ts b/apps/api/src/routes/stats/profileDetails.ts
@@ -47,18 +47,19 @@ export const get: Handler = async (req, res) => {
       `
     });
 
-    const result = await rows.json<
-      Array<{
-        actor: string;
-        most_common_browser: string;
-        most_common_browser_version: string;
-        most_common_city: string;
-        most_common_country: string;
-        most_common_os: string;
-        most_common_region: string;
-        number_of_events: string;
-      }>
-    >();
+    const result =
+      await rows.json<
+        Array<{
+          actor: string;
+          most_common_browser: string;
+          most_common_browser_version: string;
+          most_common_city: string;
+          most_common_country: string;
+          most_common_os: string;
+          most_common_region: string;
+          number_of_events: string;
+        }>
+      >();
     logger.info(`Profile details fetched for ${id}`);
 
     return res

diff --git a/apps/web/.prettierignore b/apps/web/.prettierignore
diff --git a/apps/web/package.json b/apps/web/package.json
@@ -9,8 +9,8 @@
     "dev": "next dev --port 4783",
     "lint": "eslint . --ext .ts,.tsx",
     "lint:fix": "eslint . --fix --ext .ts,.tsx",
-    "prettier": "prettier --check \"**/*.{js,ts,tsx,md}\"  --cache",
-    "prettier:fix": "prettier --write \"**/*.{js,ts,tsx,md}\"  --cache",
+    "biome": "biome check *",
+    "biome:fix": "biome check * --apply",
     "start": "next start --port 4783",
     "typecheck": "tsc --pretty"
   },

diff --git a/apps/web/public/manifest.json b/apps/web/public/manifest.json
@@ -1,22 +1,22 @@
 {
-  "id": "xyz.hey",
-  "name": "Hey",
-  "short_name": "Hey",
-  "start_url": "/",
-  "background_color": "#ffffff",
-  "theme_color": "#ffffff",
-  "display": "standalone",
-  "scope": "/",
-  "icons": [
-    {
-      "src": "/icon-128x128.png",
-      "sizes": "128x128",
-      "type": "image/png"
-    },
-    {
-      "src": "/icon-512x512.png",
-      "sizes": "512x512",
-      "type": "image/png"
-    }
-  ]
+	"id": "xyz.hey",
+	"name": "Hey",
+	"short_name": "Hey",
+	"start_url": "/",
+	"background_color": "#ffffff",
+	"theme_color": "#ffffff",
+	"display": "standalone",
+	"scope": "/",
+	"icons": [
+		{
+			"src": "/icon-128x128.png",
+			"sizes": "128x128",
+			"type": "image/png"
+		},
+		{
+			"src": "/icon-512x512.png",
+			"sizes": "512x512",
+			"type": "image/png"
+		}
+	]
 }
diff --git a/apps/web/src/components/Profile/Details.tsx b/apps/web/src/components/Profile/Details.tsx
@@ -205,9 +205,9 @@ const Details: FC<DetailsProps> = ({ profile }) => {
               </Link>
             </Tooltip>
           </MetaDetails>
-          {getProfileAttribute(profile?.metadata?.attributes, 'location') ? (
+          {getProfileAttribute('location', profile?.metadata?.attributes) ? (
             <MetaDetails icon={<MapPinIcon className="h-4 w-4" />}>
-              {getProfileAttribute(profile?.metadata?.attributes, 'location')}
+              {getProfileAttribute('location', profile?.metadata?.attributes)}
             </MetaDetails>
           ) : null}
           {profile?.onchainIdentity?.ens?.name ? (
@@ -225,7 +225,7 @@ const Details: FC<DetailsProps> = ({ profile }) => {
               {profile?.onchainIdentity?.ens?.name}
             </MetaDetails>
           ) : null}
-          {getProfileAttribute(profile?.metadata?.attributes, 'website') ? (
+          {getProfileAttribute('website', profile?.metadata?.attributes) ? (
             <MetaDetails
               icon={
                 <img
@@ -234,8 +234,8 @@ const Details: FC<DetailsProps> = ({ profile }) => {
                   height={16}
                   src={getFavicon(
                     getProfileAttribute(
-                      profile?.metadata?.attributes,
-                      'website'
+                      'website',
+                      profile?.metadata?.attributes
                     )
                   )}
                   width={16}
@@ -244,21 +244,21 @@ const Details: FC<DetailsProps> = ({ profile }) => {
             >
               <Link
                 href={`https://${getProfileAttribute(
-                  profile?.metadata?.attributes,
-                  'website'
+                  'website',
+                  profile?.metadata?.attributes
                 )
                   ?.replace('https://', '')
                   .replace('http://', '')}`}
                 rel="noreferrer noopener me"
                 target="_blank"
               >
-                {getProfileAttribute(profile?.metadata?.attributes, 'website')
+                {getProfileAttribute('website', profile?.metadata?.attributes)
                   ?.replace('https://', '')
                   .replace('http://', '')}
               </Link>
             </MetaDetails>
           ) : null}
-          {getProfileAttribute(profile?.metadata?.attributes, 'x') ? (
+          {getProfileAttribute('x', profile?.metadata?.attributes) ? (
             <MetaDetails
               icon={
                 <img
@@ -275,16 +275,16 @@ const Details: FC<DetailsProps> = ({ profile }) => {
               <Link
                 href={urlcat('https://x.com/:username', {
                   username: getProfileAttribute(
-                    profile?.metadata?.attributes,
-                    'x'
+                    'x',
+                    profile?.metadata?.attributes
                   )?.replace('https://x.com/', '')
                 })}
                 rel="noreferrer noopener"
                 target="_blank"
               >
                 {getProfileAttribute(
-                  profile?.metadata?.attributes,
-                  'x'
+                  'x',
+                  profile?.metadata?.attributes
                 )?.replace('https://x.com/', '')}
               </Link>
             </MetaDetails>

diff --git a/apps/web/src/components/Profile/MutualFollowers/index.tsx b/apps/web/src/components/Profile/MutualFollowers/index.tsx
@@ -43,16 +43,14 @@ const MutualFollowers: FC<MutualFollowersProps> = ({
       onClick={() => setShowMutualFollowersModal?.(true)}
     >
       <div className="contents -space-x-2">
-        {profiles
-          .slice(0, 3)
-          ?.map((profile) => (
-            <Image
-              alt={profile.id}
-              className="h-5 w-5 rounded-full border dark:border-gray-700"
-              key={profile.id}
-              src={getAvatar(profile)}
-            />
-          ))}
+        {profiles.slice(0, 3)?.map((profile) => (
+          <Image
+            alt={profile.id}
+            className="h-5 w-5 rounded-full border dark:border-gray-700"
+            key={profile.id}
+            src={getAvatar(profile)}
+          />
+        ))}
       </div>
       <div>
         <span>Followed by </span>

diff --git a/apps/web/src/components/Publication/HeyOpenActions/Nft/ZoraNft/Mint/MintAction.tsx b/apps/web/src/components/Publication/HeyOpenActions/Nft/ZoraNft/Mint/MintAction.tsx
@@ -122,8 +122,8 @@ const MintAction: FC<MintActionProps> = ({
     setCanMintOnHey(
       !isPrepareError ||
         (isPrepareError &&
-          ALLOWED_ERRORS_FOR_MINTING.some(
-            (error) => prepareError?.message.includes(error)
+          ALLOWED_ERRORS_FOR_MINTING.some((error) =>
+            prepareError?.message.includes(error)
           ))
     );
   }, [isPrepareFetching]);

diff --git a/apps/web/src/components/Settings/Profile/Profile.tsx b/apps/web/src/components/Settings/Profile/Profile.tsx
@@ -202,10 +202,10 @@ const ProfileSettingsForm: FC<ProfileSettingsFormProps> = ({ profile }) => {
   const form = useZodForm({
     defaultValues: {
       bio: profile?.metadata?.bio ?? '',
-      location: getProfileAttribute(profile?.metadata?.attributes, 'location'),
+      location: getProfileAttribute('location', profile?.metadata?.attributes),
       name: profile?.metadata?.displayName ?? '',
-      website: getProfileAttribute(profile?.metadata?.attributes, 'website'),
-      x: getProfileAttribute(profile?.metadata?.attributes, 'x')?.replace(
+      website: getProfileAttribute('website', profile?.metadata?.attributes),
+      x: getProfileAttribute('x', profile?.metadata?.attributes)?.replace(
         /(https:\/\/)?x\.com\//,
         ''
       )

diff --git a/biome.json b/biome.json
@@ -0,0 +1,35 @@
+{
+	"$schema": "https://biomejs.dev/schemas/1.4.1/schema.json",
+	"organizeImports": {
+		"enabled": false
+	},
+	"files": {
+		"maxSize": 100000000
+	},
+	"javascript": {
+		"formatter": {
+			"indentWidth": 2,
+			"quoteStyle": "single",
+			"trailingComma": "none",
+			"indentStyle": "space"
+		}
+	},
+	"linter": {
+		"ignore": [
+			"dist/**/*",
+			"sw.js",
+			"*.md",
+			"package.json",
+			"tsconfig.json",
+			"tsconfig.tsbuildinfo",
+			"index.html"
+		],
+		"enabled": true,
+		"rules": {
+			"a11y": { "useKeyWithClickEvents": "off" },
+			"correctness": { "useExhaustiveDependencies": "off" },
+			"suspicious": { "noExplicitAny": "off" },
+			"recommended": true
+		}
+	}
+}
diff --git a/package.json b/package.json
@@ -11,9 +11,9 @@
     "lint:affected": "turbo run lint --parallel --filter=[origin/main]",
     "lint:fix": "turbo run lint:fix --parallel",
     "prepare": "husky install",
-    "prettier": "turbo run prettier --parallel",
-    "prettier:affected": "turbo run prettier --parallel --filter=[origin/main]",
-    "prettier:fix": "turbo run prettier:fix --parallel",
+    "biome": "turbo run biome --parallel",
+    "biome:affected": "turbo run biome --parallel --filter=[origin/main]",
+    "biome:fix": "turbo run biome:fix --parallel",
     "start": "turbo run start --parallel",
     "test:dev": "turbo run test:dev",
     "typecheck": "turbo run typecheck --parallel",
@@ -23,9 +23,8 @@
     "root": true
   },
   "devDependencies": {
+    "@biomejs/biome": "^1.4.1",
     "husky": "^8.0.3",
-    "prettier": "^3.1.1",
-    "prettier-plugin-tailwindcss": "^0.5.9",
     "turbo": "^1.11.1"
   },
   "packageManager": "pnpm@8.10.5",

diff --git a/packages/abis/package.json b/packages/abis/package.json
@@ -7,8 +7,8 @@
   "scripts": {
     "lint": "eslint . --ext .ts",
     "lint:fix": "eslint . --fix --ext .ts",
-    "prettier": "prettier --check \"**/*.{js,ts,tsx,md}\"  --cache",
-    "prettier:fix": "prettier --write \"**/*.{js,ts,tsx,md}\"  --cache",
+    "biome": "biome check *",
+    "biome:fix": "biome check * --apply",
     "typecheck": "tsc --pretty"
   },
   "devDependencies": {

diff --git a/packages/config/eslint/base.js b/packages/config/eslint/base.js
@@ -12,15 +12,13 @@ module.exports = {
   plugins: [
     '@typescript-eslint',
     'unused-imports',
-    'prettier',
     'unicorn',
     'import',
     'perfectionist'
   ],
   rules: {
     curly: 'error',
     'no-unused-vars': 'off',
-    'prettier/prettier': 'error',
     'unused-imports/no-unused-imports': 'error',
     'import/no-duplicates': ['error', { considerQueryString: true }],
     'prefer-destructuring': ['error', { VariableDeclarator: { object: true } }],

diff --git a/packages/config/package.json b/packages/config/package.json
@@ -11,7 +11,6 @@
     "eslint": "^8.55.0",
     "eslint-config-next": "^14.0.4",
     "eslint-plugin-perfectionist": "^2.5.0",
-    "eslint-plugin-prettier": "^5.0.1",
     "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-simple-import-sort": "^10.0.0",

diff --git a/packages/data/hashflags.ts b/packages/data/hashflags.ts
@@ -16,5 +16,6 @@ export const hashflags: Record<string, string> = {
   lens: 'lens',
   lenstube: 'lenstube',
   voted: 'voted',
+  // biome-ignore lint/performance/noAccumulatingSpread: <explanation>
   ...prideHashtags.reduce((acc, cur) => ({ ...acc, [cur]: 'pride' }), {})
 };