Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: image duplicated when multiple upload #1350

Merged
merged 2 commits into from
Dec 4, 2022
Merged

fix: image duplicated when multiple upload #1350

merged 2 commits into from
Dec 4, 2022

Conversation

hungds99
Copy link
Contributor

@hungds99 hungds99 commented Dec 4, 2022

What does this PR do?

Fixes # (issue)

https://www.loom.com/share/aebdcbd7b0be4567837a803d074d610a

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@hungds99 hungds99 requested a review from bigint as a code owner December 4, 2022 07:43
@vercel
Copy link

vercel bot commented Dec 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 8:01AM (UTC)
pro ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 8:01AM (UTC)
web ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 8:01AM (UTC)

@vercel vercel bot temporarily deployed to Preview – api December 4, 2022 07:45 Inactive
@vercel vercel bot temporarily deployed to Preview – pro December 4, 2022 07:49 Inactive
@hungds99
Copy link
Contributor Author

hungds99 commented Dec 4, 2022 •
edited
Loading

Fix images order
https://www.loom.com/share/fb3a4fa13cf24f91be3b42fb2828e03f

@vercel vercel bot temporarily deployed to Preview – api December 4, 2022 07:59 Inactive
@vercel vercel bot temporarily deployed to Preview – pro December 4, 2022 08:01 Inactive
bigint
bigint approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint bigint merged commit 88e6872 into heyxyz:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigint bigint bigint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hungds99 @bigint