Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nft detail page UI #1700

Merged
merged 236 commits into from
Feb 1, 2023
Merged

feat: nft detail page UI #1700

merged 236 commits into from
Feb 1, 2023

Conversation

sasicodes
Copy link
Contributor

@sasicodes sasicodes commented Jan 31, 2023

What does this PR do?

Link T-2572

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@height
Copy link

height bot commented Jan 31, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-2572" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
api ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 1, 2023 at 5:42AM (UTC)
embed ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 1, 2023 at 5:42AM (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 1, 2023 at 5:42AM (UTC)

@sasicodes sasicodes changed the title feat: NFT detail page UI feat: nft detail page UI Jan 31, 2023
@vercel vercel bot temporarily deployed to Preview – embed January 31, 2023 09:27 Inactive
@vercel vercel bot temporarily deployed to Preview – api January 31, 2023 09:29 Inactive
@sasicodes sasicodes self-assigned this Jan 31, 2023
@sasicodes sasicodes marked this pull request as ready for review January 31, 2023 11:30
@vercel vercel bot temporarily deployed to Preview – api February 1, 2023 05:41 Inactive
@vercel vercel bot temporarily deployed to Preview – embed February 1, 2023 05:42 Inactive
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint bigint merged commit 6692844 into main Feb 1, 2023
@bigint bigint deleted the nft-detail branch February 1, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants