Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send message and attachment #2882

Merged
merged 6 commits into from
May 18, 2023
Merged

Conversation

elisealix22
Copy link
Contributor

What does this PR do?

Allows users to send both an attachment and a message. Also adds fallback text for XMTP apps that don't support attachments yet. Finally, it makes it so you can't dismiss an attachment while it is being sent.

Related issues

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

Go to send an attachment or a message. Either or both should work.

Emoji

👯

@elisealix22 elisealix22 requested a review from bigint as a code owner May 17, 2023 19:48
@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview May 18, 2023 3:12pm
ui ✅ Ready (Inspect) Visit Preview May 18, 2023 3:12pm
web ✅ Ready (Inspect) Visit Preview May 18, 2023 3:12pm

Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint
Copy link
Member

bigint commented May 18, 2023

image

Maybe we can merge text and attachment together! that's for next 🙇🏼

@bigint bigint merged commit f361230 into heyxyz:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants