Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get community by slug and id #3338

Merged
merged 1 commit into from
Jul 23, 2023
Merged

feat: add get community by slug and id #3338

merged 1 commit into from
Jul 23, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Jul 23, 2023

What does this PR do?

🤖 Generated by Copilot at ba54743

Refactored and renamed the communities worker and its endpoints to support querying communities by id or slug and to improve consistency and clarity. Updated the web app components that use the communities worker to match the new endpoints and naming convention.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at ba54743

  • Update axios requests in web components to use new endpoints (link, link, link, link)
  • Modify getCommunity handler in communities worker to accept type parameter and query by either id or slug (link, link)
  • Rename handlers and endpoints in communities worker to follow /get convention and avoid name clashes (link, link, link, link)

Emoji

🛠️🔎🚀

@vercel
Copy link

vercel bot commented Jul 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Jul 23, 2023 4:07am
web ✅ Ready (Inspect) Visit Preview Jul 23, 2023 4:07am

@bigint bigint merged commit c357d93 into main Jul 23, 2023
4 checks passed
@bigint bigint deleted the get-by-id branch July 23, 2023 04:05
@vercel vercel bot temporarily deployed to Preview – prerender July 23, 2023 04:05 Inactive
Comment on lines +26 to +28
const response = await axios(
`${COMMUNITIES_WORKER_URL}/getCommunityBySlug/${slug}`
);

Check failure

Code scanning / CodeQL

Server-side request forgery Critical

The
URL
of this request depends on a
user-provided value
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant