Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add key for FullPublication #3654

Conversation

foolo
Copy link
Contributor

@foolo foolo commented Aug 30, 2023

What does this PR do?

🤖 Generated by Copilot at d3fdab5

Added key prop to FullPublication component in apps/web/src/components/Publication/index.tsx to improve rendering performance and avoid errors. Used publication?.id as the key value.

Related issues

Fixes #3652

After:

Screencast.2023-08-30.14.56.28.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖 Generated by Copilot at d3fdab5

  • Add key prop to FullPublication component to prevent rendering issues (link)

Emoji

🔑🆔🔄

@foolo foolo requested a review from bigint as a code owner August 30, 2023 12:54
@foolo foolo linked an issue Aug 30, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Aug 30, 2023 0:56am
web ✅ Ready (Inspect) Visit Preview Aug 30, 2023 0:56am

@foolo foolo changed the title add key for FullPublication fix: add key for FullPublication Aug 30, 2023
@vercel vercel bot temporarily deployed to Preview – prerender August 30, 2023 12:56 Inactive
@bigint bigint merged commit c8a87d7 into main Aug 30, 2023
10 checks passed
@bigint bigint deleted the 3652-weird-cache-behaviour-while-navigating-between-post-and-its-comment branch August 30, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird cache behaviour while navigating between post and its comment
2 participants