Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent blankline commits #3858

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat: prevent blankline commits #3858

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2271110
prevent blankline commits
melsonic Oct 2, 2023
7cdc723
prevent blankline commits: updated crowdin workflow file
melsonic Oct 3, 2023
32173f2
prevent blankline commits: updated crowdin workflow file
melsonic Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/crowdin-download.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@ jobs:
translation: '/**/locales/%two_letters_code%/%original_file_name%'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Remove last empty lines from translations
run: |
find '/**/locales/' -type f -name '*.po' -exec sed -i -e '${/^$/d;}' {} \;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested this? if we add here how it will remove after the file is being pushed on previous step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think instead of creating a pull request during the Download from Crowdin ⬇️ step, we should be creating a pull request at the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the workflow?

1 change: 1 addition & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"


pnpm lint:affected
pnpm typecheck:affected