Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add message preview component #779

Merged
merged 42 commits into from
Oct 12, 2022
Merged

feat: add message preview component #779

merged 42 commits into from
Oct 12, 2022

Conversation

elisealix22
Copy link
Contributor

@elisealix22 elisealix22 commented Oct 10, 2022 •
edited

What does this PR do?

This PR maps Lens profiles to XMTP accounts and only shows messages for conversations that include a valid Lens profile.

This is a work in progress and behind the messages feature flag. Some known issues include:

  • Right now the preview shows the first message not the most recent
  • The conversations in the left panel are not sorted correctly
  • Pieces are duplicated between Message and Messages. They should be pulled out into their own ConversationList component.

Screen Shot 2022-10-10 at 2 57 29 PM

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Ensure you're in the FF and navigate to Messages
  • You should see a list of all your current DM conversations with Lens profiles
  • Tapping the cell should open the message list component

Elise Alix and others added 30 commits October 4, 2022 15:26
feat: add message button to profile using xmtp
61a914a
address review feedback
e0e0086
Merge remote-tracking branch 'origin/main' into ea/add-profile-msg-btn
c0190d6
@bhavya2611
added xmtp and added conversations and messages to the store
44f4f42
@bhavya2611
added route for converations
15faa0d
@bhavya2611
added hook for streaming messages
96bfd31
@bhavya2611
added converation page and message page
5cc3373
@bhavya2611
addressed review comments
4b33e85
@bhavya2611
updated import for old messages page
9f00d39
@bhavya2611
conversation list component added
859fef7
@bhavya2611
message list component added
c9248f0
@bhavya2611
Revert "message list component added"
eb72f88 
This reverts commit aec87b1.
@bhavya2611
Revert "conversation list component added"
af107c9 
This reverts commit 2663f17.
@bhavya2611
put all new code behind feature flag check and removed old messages code
8f05e8f
@bhavya2611
added seo back and added bhavyas profile to featured flag list
3e09f12
fix spelling error and lint warnings
f3e44eb
Merge remote-tracking branch 'origin/main' into feat/setup-xmtp-req
8318575
@bigint
Merge branch 'main' into feat/setup-xmtp-req
aec4aaf
Revert "fix spelling error and lint warnings"
0a4fed8 
This reverts commit f3e44eb.
fix spelling error and disable exhaustive hooks warning
20bdb2b
Merge remote-tracking branch 'origin/feat/setup-xmtp-req' into feat/s…
8dba5af 
…etup-xmtp-req
feat: add conversation preview component
cc29054
Merge remote-tracking branch 'origin/main' into ea/add-convo-preview
e77f3a6
grab data from graphql for profiles
fe08afd
add profilemessage data type to pair lens & xmtp data
368b52e
Merge remote-tracking branch 'origin/main' into ea/add-convo-preview
ee05a90
populate message preview
e6f095d
ensure a match between lens and xmtp accts before showing
52db08a
add todo to sort messages by descending order
71bb1f4
tidy up before PR
ff951c8
@vercel vercel bot temporarily deployed to Preview October 11, 2022 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 15:33 Inactive
@elisealix22
Copy link
Contributor Author

Caught up with @bhavya2611 and we're aligned on the future of the component structure / state handling. I'll be adding a new ConverstaionList component to handle most of this state in the next PR.

@vercel vercel bot temporarily deployed to Preview October 11, 2022 15:37 Inactive
bhavya2611
bhavya2611 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@bhavya2611 bhavya2611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me.

@vercel vercel bot temporarily deployed to Preview October 11, 2022 16:34 Inactive
@elisealix22 elisealix22 mentioned this pull request Oct 11, 2022
Merged
4 tasks
@vercel vercel bot temporarily deployed to Preview October 12, 2022 04:43 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 04:54 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 10:20 Inactive
@elisealix22
Copy link
Contributor Author

Alright, should be all set now! Thank you everyone for the reviews!

@vercel vercel bot temporarily deployed to Preview October 12, 2022 10:34 Inactive
bigint
bigint approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@bigint bigint enabled auto-merge October 12, 2022 10:35
@bigint bigint merged commit 5208544 into main Oct 12, 2022
@bigint bigint deleted the ea/add-convo-preview branch October 12, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

@bhavya2611 bhavya2611 bhavya2611 approved these changes

@bigint bigint bigint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elisealix22 @neekolas @bhavya2611 @bigint