Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: markdown links support #854

Merged
merged 8 commits into from
Oct 18, 2022
Merged

feat: markdown links support #854

merged 8 commits into from
Oct 18, 2022

Conversation

keivinonline
Copy link
Contributor

What does this PR do?

Fixes #35

  • Have utilized existing interweave markups to match for the [Markdown Guide](https://www.markdownguide.org) pattern
issue_35_01.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • To test in vercel build if the posted message is same as preview.

@vercel
Copy link

vercel bot commented Oct 18, 2022

@0xkeivin is attempting to deploy a commit to the Lenster Team on Vercel.

A member of the Team first needs to authorize it.

@keivinonline keivinonline changed the title Feat/markdown support Feat/markdown links support Oct 18, 2022
@keivinonline keivinonline changed the base branch from main to testnet October 18, 2022 06:48
@bigint bigint changed the title Feat/markdown links support feat: markdown links support Oct 18, 2022
@vercel
Copy link

vercel bot commented Oct 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 7:32AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 18, 2022 07:32 Inactive
bigint
bigint reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @0xkeivin 👏🏼

LGTM :shipit:

Rad LGTM

@bigint bigint merged commit e85fdde into heyxyz:testnet Oct 18, 2022
bigint added a commit that referenced this pull request Oct 18, 2022
@bigint
Revert "feat: markdown links support (#854)"
93b5864 
This reverts commit e85fdde.
@bigint bigint mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigint bigint bigint left review comments

Assignees

@keivinonline keivinonline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Markdown links support
2 participants
@keivinonline @bigint