Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webbed fingers of ok and pinching emoji #86

Closed
wants to merge 1 commit into from

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Nov 29, 2019

#72 The effect is visible on dark backgrounds

image

@b-g
Copy link
Member

b-g commented Nov 29, 2019

Many thanks! But I would like to discuss this with Daniel @dnlutz quickly. As it relates to one of the big open issues #31 ... the way forward might be simply a white additional outline around everything to differentiate our emojis properly on dark backgrounds.

@carlinmack
Copy link
Contributor Author

carlinmack commented Nov 30, 2019

Trying to mock that up now and it's harder than it seems hmm figured it out. Top row is 'webbed' and bottom is my PR . I think I prefer top right

image

@b-g
Copy link
Member

b-g commented Dec 2, 2019

@carlinmack Many thanks for this! But we will turn down this PR ... We think it is better to address and fix the issue in general and not just for a few ones. Sorry! Hope you understand.

@b-g b-g closed this Dec 2, 2019
@carlinmack
Copy link
Contributor Author

yep it's a bigger issue than this PR

@carlinmack carlinmack mentioned this pull request Jan 3, 2020
37 tasks
@carlinmack carlinmack mentioned this pull request Mar 21, 2020
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants