Moved to RC8 of pear/OLE #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looking at the commit description, did you back-door that into |
:D Yes, I have refactored it to support the streams :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have recently done many fixes in the pear/OLE library and along the changes, I also refactored the creation of the document from stream. After this change, there is no need to have a copy of the code (and keep it update) in this library, we can use the readStream() from the OLE to achieve the same thing.
I have also fixed the reading of properties, as we have several files, that crashed on the "read beyond file". It's simple condition, that will skip the property.
I have also some other fixes, but I will make another PR after merging this one.
Thanks,
Richard.