Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for NA servers #111

Merged
merged 4 commits into from Aug 7, 2023
Merged

Added support for NA servers #111

merged 4 commits into from Aug 7, 2023

Conversation

Externoak
Copy link
Contributor

@Externoak Externoak commented Aug 6, 2023 •
edited

Added support for NA server, images that have been created and tested:

  • arts.png
  • buster.png
  • cardsealed.png (TODO In a later moment)
  • charasealed.png (TODO In a later moment)
  • defeated.png
  • dropitem.png
  • hougusealed.png
  • quick.png
  • still.png
  • synthesis.png

hgjazhgj
hgjazhgj reviewed Aug 6, 2023
View reviewed changes
FGO-py/fgoDetect.py Outdated Show resolved Hide resolved
@hgjazhgj hgjazhgj added the enhancement New feature or request label Aug 6, 2023
hgjazhgj
hgjazhgj reviewed Aug 7, 2023
View reviewed changes
FGO-py/fgoDetect.py Outdated Show resolved Hide resolved
@hgjazhgj
Copy link
Owner

hgjazhgj commented Aug 7, 2023

I think there is nothing else todo for now and all your code will work well.
Once you mark this pr as Ready for review, I will merge it.
You can add charasealed and/orcardsealed when you actually meet them, with another pr, in future. Since cardealed seems like it hasn't been around in years :)

@Externoak Externoak marked this pull request as ready for review August 7, 2023 17:40
@hgjazhgj hgjazhgj merged commit 5c9f7d7 into hgjazhgj:master Aug 7, 2023
@hgjazhgj
Copy link
Owner

hgjazhgj commented Aug 7, 2023

Please note that your images are not saved by cv2.imwrite(filename,image,[cv2.IMWRITE_PNG_COMPRESSION,9]) as I mentioned in email.
5493ea3

@Externoak
Copy link
Contributor Author

Please note that your images are not saved by cv2.imwrite(filename,image,[cv2.IMWRITE_PNG_COMPRESSION,9]) as I mentioned in email. 5493ea3

Oversight on my side, thanks for the quick fix :)

@miquve miquve mentioned this pull request Aug 26, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgjazhgj hgjazhgj hgjazhgj left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Externoak @hgjazhgj